Skip to content

Minor fix(?) for lsp-ui-imenu--visit and lsp-ui-imenu--view #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
emacksnotes opened this issue Apr 21, 2019 · 3 comments · May be fixed by #753
Open

Minor fix(?) for lsp-ui-imenu--visit and lsp-ui-imenu--view #274

emacksnotes opened this issue Apr 21, 2019 · 3 comments · May be fixed by #753
Labels
ui-imenu

Comments

@emacksnotes
Copy link

emacksnotes commented Apr 21, 2019 •
edited
Loading

In lsp-ui-imenu--visit and lsp-ui-imenu--view, replace

(goto-char marker)

with

(goto-char (overlay-start marker))

Without the above changes I get the following error

funcall-interactively: Wrong type argument: integer-or-marker-p, #<overlay from 16721 to 16752 in xdisp.c>
@c02y
Copy link

c02y commented Sep 11, 2020 •
edited
Loading

@emacksnotes Agree, I got the same problem, your code line fixes it.

It's over a year, maybe post a PR?

UPDATE:
I was wrong, the fix-code works only for some simple file such as a source not managed by ccls/lsp, for projects(compile_commands.json), it doesn't work.

Without the fix, In lsp-ui-imenu--visit and lsp-ui-imenu--view works without problem.

@jcs090218
Copy link
Member

@emacksnotes @c02y Feel free to open a PR! There will be people reviewing it! 😄

@c02y
Copy link

c02y commented Sep 11, 2020 •
edited
Loading

@jcs090218 I added an update, this fix will break those two functions.

But for a simple source file, lsp-ui-imenu--visit and lsp-ui-imenu--view functions should work too. It still needs update, just not simple (goto-char (overlay-start marker))

@stskyblade stskyblade linked a pull request Jun 26, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui-imenu
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong type error in lsp-ui-imenu--view stskyblade/lsp-ui
3 participants
@c02y @jcs090218 @emacksnotes