Merge pull request #611 from emacs-php/miniknN-php-faces

Improve class faces

Author: zonuexe

php-face.el

@@ -201,6 +201,11 @@
   :group 'php-faces
   :tag "PHPDoc Class Name")
 
+(defface php-class-declaration '((t (:inherit php-keyword)))
+  "Face used to class declarations."
+  :group 'php-faces
+  :tag "PHP Class Declaration")
+
 (define-obsolete-face-alias 'php-annotations-annotation-face 'php-doc-annotation-tag "1.19.0")
 
 (provide 'php-face)

php-mode.el

@@ -1533,6 +1533,8 @@ a completion list."
       1 'php-class)
      ;; Support the ::class constant in PHP5.6
      ("\\sw+\\(::\\)\\(class\\)\\b" (1 'php-paamayim-nekudotayim) (2 'php-magical-constant))
+     ;; Class declaration keywords (class, trait, interface)
+     ("\\_<\\(class\\|trait\\|interface\\)\\_>" . 'php-class-declaration)
 
      ;; Highlight static method calls as such. This is necessary for method
      ;; names which are identical to keywords to be highlighted correctly.

tests/7.4/typed-property.php.faces

@@ -1,7 +1,7 @@
 ;; -*- mode: emacs-lisp -*-
 (("<?php" . php-php-tag)
  ("\n\n")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" ")
  ("Typed" . font-lock-type-face)
  ("\n{\n    ")

tests/issue-136.php.faces

@@ -64,7 +64,7 @@
  ("\n")
  ("final" . php-keyword)
  (" ")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" ")
  ("SampleClass" . font-lock-type-face)
  ("\n{\n    ")

tests/lang/class/anonymous-class.php.faces

@@ -8,7 +8,7 @@
  (" ")
  ("new" . php-keyword)
  (" ")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" () ")
  ("extends" . php-keyword)
  (" ")
@@ -21,12 +21,12 @@
  ("(1, ")
  ("new" . php-keyword)
  (" ")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" () ")
  ("extends" . php-keyword)
  (" ")
  ("IteratorAggregate" . font-lock-type-face)
  (" {\n    ")
  ("// " . font-lock-comment-delimiter-face)
  ("###php-mode-test### ((indent 4))\n" . font-lock-comment-face)
- ("});\n"))
+ ("});\n"))

tests/lang/doc-comment/annotation.php.faces

@@ -7,7 +7,7 @@
  ("@MyProject\\Annotations\\Foobarable" php-doc-annotation-tag font-lock-doc-face)
  ("\n */" . font-lock-doc-face)
  ("\n")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" ")
  ("User" . font-lock-type-face)
  ("\n{\n}\n\n")
@@ -20,7 +20,7 @@
  ("myProperty" php-variable-name font-lock-doc-face)
  ("\n */" . font-lock-doc-face)
  ("\n")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" ")
  ("Child" . font-lock-type-face)
  (" ")

tests/lang/doc-comment/comments.php.24.faces

@@ -64,7 +64,7 @@
  ("\n")
  ("final" . php-keyword)
  (" ")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" ")
  ("SampleClass" . font-lock-type-face)
  ("\n{\n    ")

tests/lang/doc-comment/comments.php.27.faces

@@ -65,7 +65,7 @@
  ("\n")
  ("final" . php-keyword)
  (" ")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" ")
  ("SampleClass" . font-lock-type-face)
  ("\n{\n    ")

tests/lang/doc-comment/comments.php.faces

@@ -64,7 +64,7 @@
  ("\n")
  ("final" . php-keyword)
  (" ")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" ")
  ("SampleClass" . font-lock-type-face)
  ("\n{\n    ")

tests/lang/doc-comment/issue-8.php.faces

@@ -11,7 +11,7 @@
  ("@ORM\\Table" php-doc-annotation-tag font-lock-doc-face)
  ("(name=\"product\")\n */" . font-lock-doc-face)
  ("\n")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" ")
  ("Product" . font-lock-type-face)
  ("\n{\n    ")

tests/language-constructs.php

@@ -19,7 +19,6 @@
 break;
 case;
 catch;
-class ClassName;
 clone;
 const;
 continue;
@@ -53,7 +52,6 @@ function;
 include_once;
 instanceof ClassName;
 insteadof ClassName;
-interface ClassName;
 isset();
 list();
 namespace ClassName;
@@ -68,7 +66,6 @@ interface ClassName;
 static;
 switch;
 throw;
-trait ClassName;
 try;
 unset();
 use ClassName;

tests/type-hints.php.faces

@@ -1,7 +1,7 @@
 ;; -*- mode: emacs-lisp -*-
 (("<?php" . php-php-tag)
  ("\n\n")
- ("class" . php-keyword)
+ ("class" . php-class-declaration)
  (" ")
  ("SomeClass" . font-lock-type-face)
  ("\n{\n    ")