-
Notifications
You must be signed in to change notification settings - Fork 119
Config mode is chosen for Zend config files #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I see. I searched through the open issues and couldn't find anything related. |
@sg2002 |
They are not yet merged because I felt it was necessary to make a few changes and that has taken longer than I planned. Even though this seems like a trivial, simple bug to fix, please keep in mind that if I make a mistake and push out a bugged release then that affects a lot of people badly. In the past I have rushed to push bug fixes only to find out it caused tons of new errors for all PHP Mode users who keep their version up to date. So nowadays I am very cautious about certain merges. @zonuexe I still intend to merge your branches, but it is taking me longer than I expected to tweak and test them thoroughly so that I am confident that I am not going to break PHP Mode when I do finally merge them. I'm sorry about the delay though. |
@ejmr |
Same, I appreciate your patience. |
Zend framework often has config files with names that follow pattern "*.config.php". In auto-mode-alist there's this pattern ("[/.]c\(?:on\)?f\(?:i?g\)?\(?:\.[a-zA-Z0-9._-]+\)?\'" . conf-mode-maybe) - that selects conf-mode for them.
Since php-mode adds its patterns to the end of auto-mode-alist, the needed pattern just never fires. I see two options - add patterns to the front, but this may lead with compatibility problems with e. g. web-mode, or add patterns precisely just before the conf pattern.
The text was updated successfully, but these errors were encountered: