Skip to content

Config mode is chosen for Zend config files #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sg2002 opened this issue Jul 29, 2017 · 6 comments
Closed

Config mode is chosen for Zend config files #367

sg2002 opened this issue Jul 29, 2017 · 6 comments

Comments

@sg2002
Copy link

sg2002 commented Jul 29, 2017

Zend framework often has config files with names that follow pattern "*.config.php". In auto-mode-alist there's this pattern ("[/.]c\(?:on\)?f\(?:i?g\)?\(?:\.[a-zA-Z0-9._-]+\)?\'" . conf-mode-maybe) - that selects conf-mode for them.
Since php-mode adds its patterns to the end of auto-mode-alist, the needed pattern just never fires. I see two options - add patterns to the front, but this may lead with compatibility problems with e. g. web-mode, or add patterns precisely just before the conf pattern.

@zonuexe
Copy link
Member

zonuexe commented Jul 29, 2017

This problem is same as #362. I want to merge #362 or #363.

The two PRs(#362 and #363) are exclusive. This problem will be solved if either is merged.

@sg2002
Copy link
Author

sg2002 commented Jul 29, 2017

I see. I searched through the open issues and couldn't find anything related.

@sg2002 sg2002 closed this as completed Jul 29, 2017
@zonuexe
Copy link
Member

zonuexe commented Jul 29, 2017

@sg2002
Your report was very valuable because both of these PRs have not yet been merged.
I recognized this problem for a long time, but the report was delayed. I'm sorry I bothered you. 🙇

@ejmr
Copy link
Collaborator

ejmr commented Jul 29, 2017

They are not yet merged because I felt it was necessary to make a few changes and that has taken longer than I planned. Even though this seems like a trivial, simple bug to fix, please keep in mind that if I make a mistake and push out a bugged release then that affects a lot of people badly. In the past I have rushed to push bug fixes only to find out it caused tons of new errors for all PHP Mode users who keep their version up to date. So nowadays I am very cautious about certain merges.

@zonuexe I still intend to merge your branches, but it is taking me longer than I expected to tweak and test them thoroughly so that I am confident that I am not going to break PHP Mode when I do finally merge them. I'm sorry about the delay though.

@zonuexe
Copy link
Member

zonuexe commented Jul 29, 2017

@ejmr
I am afraid to break the environment of users, too. I appreciate your consideration.

@ejmr
Copy link
Collaborator

ejmr commented Jul 29, 2017

Same, I appreciate your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants