Skip to content

Add tsx to auto-mode-alist #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yasushi-saito opened this issue Mar 4, 2020 · 2 comments
Closed

Add tsx to auto-mode-alist #130

yasushi-saito opened this issue Mar 4, 2020 · 2 comments

Comments

@yasushi-saito
Copy link

Changing the next-to-last line to:

(add-to-list 'auto-mode-alist '("\.tsx?$" . typescript-mode))

should work.

@lddubeau
Copy link
Collaborator

lddubeau commented Mar 4, 2020

This mode does not currently support tsx. We're not going to add .tsx to the auto-mode-alist until the mode does support tsx. Adding it to the list without proper support would just confuse users who (reasonably) expect that if the mode modifies auto-mode-alist to associate tsx with this mode, then this mode supports tsx.

See #4

In order for tsx support to be added, someone who needs this support will have to step up and do the work. Given that none of the collaborators on this project have done anything about it in 4 years, I would not wait for us to act.

@josteink
Copy link
Member

josteink commented Mar 5, 2020

If that change works for you and the way you use TSX, good for you. You can add it to your init.el and ensure everything works as you like it on your end.

On our part though, I agree with @lddubeau: I don't want to give other Emacs-users a false sense of what they can expect to work and to be supported. In that respect it's IMO better to be conservative than liberal. Users (like yourself) are free to expand the auto-mode list depending on their own preferences, after all.

Until we have a "regular" TSX-user onboard who is willing to test and review TSX-related changes, I doubt typescript-mode will be able to support this.

@lddubeau lddubeau mentioned this issue Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants