Skip to content

Commit 3c0e3ff

Browse files
author
Robert Jackson
authored
Do not assume global variables are assigned to self. (#205)
Do not assume global variables are assigned to `self`.
2 parents 6563435 + 8a0dff8 commit 3c0e3ff

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

Diff for: addon/index.ts

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
declare global {
2+
var requirejs: {
3+
_eak_seen: Object;
4+
};
5+
}
6+
17
import Engine from '@ember/engine';
28
import require from 'require';
39

@@ -39,7 +45,7 @@ export default function loadInitializers(app: typeof Engine, prefix: string): vo
3945
var instanceInitializers = [];
4046
// this is 2 pass because generally the first pass is the problem
4147
// and is reduced, and resolveInitializer has potential to deopt
42-
var moduleNames = Object.keys(self.requirejs._eak_seen);
48+
var moduleNames = Object.keys(requirejs._eak_seen);
4349
for (var i = 0; i < moduleNames.length; i++) {
4450
var moduleName = moduleNames[i];
4551
if (moduleName.lastIndexOf(initializerPrefix, 0) === 0) {

Diff for: package.json

+3
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,9 @@
7676
"release-it-lerna-changelog": "^1.0.3",
7777
"typescript": "^3.6.3"
7878
},
79+
"resolutions": {
80+
"**/engine.io": "~3.3.0"
81+
},
7982
"engines": {
8083
"node": "6.* || 8.* || >= 10.*"
8184
},

0 commit comments

Comments
 (0)