Merge pull request #20590 from emberjs/yalc-shave

Restore a working linking setup for glimmer-vm packages

Author: chancancode

bin/link-glimmer-vm-packages.mjs

@@ -0,0 +1,15 @@
+import { readFileSync } from 'node:fs';
+import execa from 'execa';
+
+const packageJsonPath = new URL('../package.json', import.meta.url).pathname;
+const packageJson = JSON.parse(await readFileSync(packageJsonPath, { encoding: 'utf8' }));
+
+function shouldLink(dep) {
+  return dep.startsWith('@glimmer/') && dep !== '@glimmer/component' && dep !== '@glimmer/env';
+}
+
+for (const [dep] of Object.entries(packageJson.dependencies)) {
+  if (shouldLink(dep)) {
+    await execa('pnpm', ['link', '--global', dep], { stdio: 'inherit' });
+  }
+}

broccoli/packages.js

@@ -225,10 +225,10 @@ function glimmerTrees(packageNames) {
   let pkg;
 
   while ((pkg = queue.pop()) !== undefined) {
-    if (seen.has(pkg)) {
+    if (seen.has(pkg.name)) {
       continue;
     }
-    seen.add(pkg);
+    seen.add(pkg.name);
 
     if (!pkg.name.startsWith('@glimmer/') && !pkg.name.startsWith('@simple-dom/')) {
       continue;

package.json

@@ -38,6 +38,7 @@
     "build": "npm-run-all build:*",
     "docs": "ember ember-cli-yuidoc",
     "start": "ember serve",
+    "link:glimmer-vm": "node bin/link-glimmer-vm-packages.mjs",
     "lint": "npm-run-all --continue-on-error --aggregate-output --parallel \"lint:!(fix)\"",
     "lint:docs": "qunit tests/docs/coverage-test.js",
     "lint:eslint": "eslint --report-unused-disable-directives --cache .",