Merge pull request #20593 from emberjs/isolated-modules

Enable tsconfig isolatedModules

Author: ef4

package.json

@@ -111,10 +111,9 @@
     "@embroider/shared-internals": "^2.5.0",
     "@rollup/plugin-babel": "^6.0.3",
     "@simple-dom/document": "^1.4.0",
-    "@swc/core": "^1.3.100",
     "@swc-node/register": "^1.6.8",
+    "@swc/core": "^1.3.100",
     "@tsconfig/ember": "^2.0.0",
-    "@types/node": "^18.11.11",
     "@types/qunit": "^2.19.4",
     "@types/rsvp": "^4.0.4",
     "@typescript-eslint/eslint-plugin": "^5.59.8",

packages/@ember/-internals/container/index.ts

@@ -5,5 +5,5 @@ The public API, specified on the application namespace should be considered the
   @private
 */
 
-export { default as Registry, ResolverClass, privatize } from './lib/registry';
+export { default as Registry, type ResolverClass, privatize } from './lib/registry';
 export { default as Container, getFactoryFor, setFactoryFor, INIT_FACTORY } from './lib/container';

packages/@ember/-internals/container/lib/container.ts

@@ -18,6 +18,10 @@ interface LeakTracking {
   reset(): void;
 }
 
+// node exposes this. I'm not pulling in the whole @types/node because it
+// doesn't work with isolatedModules
+declare const gc: undefined | (() => void);
+
 let leakTracking: LeakTracking;
 let containers: WeakSet<Container>;
 if (DEBUG) {
@@ -32,7 +36,6 @@ if (DEBUG) {
         containers = new WeakSet<Container>();
         return {
           hasContainers() {
-            // @ts-expect-error We just checked if it is definied
             gc();
             return GetWeakSetValues(containers).length > 0;
           },

packages/@ember/-internals/environment/lib/global.ts

@@ -1,4 +1,4 @@
-/* globals global, window, self */
+/* globals window, self */
 declare const mainContext: object | undefined;
 
 // from lodash to catch fake globals
@@ -11,6 +11,8 @@ function checkElementIdShadowing(value: any | null | undefined) {
   return value && value.nodeType === undefined ? value : undefined;
 }
 
+declare const global: unknown;
+
 // export real global
 export default checkGlobal(checkElementIdShadowing(typeof global === 'object' && global)) ||
   checkGlobal(typeof self === 'object' && self) ||

packages/@ember/-internals/glimmer/index.ts

@@ -464,7 +464,7 @@ export {
   hasTemplate,
   getTemplates,
   setTemplates,
-  TemplatesRegistry,
+  type TemplatesRegistry,
 } from './lib/template_registry';
 export { setupEngineRegistry, setupApplicationRegistry } from './lib/setup-registry';
 export { DOMChanges, NodeDOMTreeConstruction, DOMTreeConstruction } from './lib/dom';
@@ -473,8 +473,8 @@ export { DOMChanges, NodeDOMTreeConstruction, DOMTreeConstruction } from './lib/
 // TODO just test these through public API
 // a lot of these are testing how a problem was solved
 // rather than the problem was solved
-export { default as OutletView, BootEnvironment } from './lib/views/outlet';
-export { OutletState, RenderState } from './lib/utils/outlet';
+export { default as OutletView, type BootEnvironment } from './lib/views/outlet';
+export type { OutletState, RenderState } from './lib/utils/outlet';
 export {
   componentCapabilities,
   modifierCapabilities,

packages/@ember/-internals/glimmer/lib/component.ts

@@ -20,7 +20,7 @@ import { isUpdatableRef, updateRef } from '@glimmer/reference';
 import { normalizeProperty } from '@glimmer/runtime';
 import type { DirtyableTag } from '@glimmer/validator';
 import { createTag, dirtyTag } from '@glimmer/validator';
-import { Namespace, type SimpleElement } from '@simple-dom/interface';
+import type { SimpleElement } from '@simple-dom/interface';
 import {
   ARGS,
   BOUNDS,
@@ -1000,7 +1000,7 @@ class Component<S = unknown>
     );
 
     let element = _element;
-    let isSVG = element.namespaceURI === Namespace.SVG;
+    let isSVG = element.namespaceURI === 'http://www.w3.org/2000/svg';
     let { type, normalized } = normalizeProperty(element as unknown as SimpleElement, name);
 
     if (isSVG || type === 'attr') {

packages/@ember/-internals/glimmer/lib/glimmer-component-docs.ts

@@ -383,3 +383,5 @@
   @module @glimmer/component
   @public
 */
+
+export {};

packages/@ember/-internals/glimmer/lib/glimmer-tracking-docs.ts

@@ -242,3 +242,5 @@
   @for @glimmer/tracking
   @public
  */
+
+export {};

packages/@ember/-internals/glimmer/lib/helpers/array.ts

@@ -37,3 +37,4 @@
    @since 3.8.0
    @public
  */
+export {};

packages/@ember/-internals/glimmer/lib/helpers/component.ts

@@ -145,3 +145,5 @@
   @for Ember.Templates.helpers
   @public
 */
+
+export {};

packages/@ember/-internals/glimmer/lib/helpers/concat.ts

@@ -24,3 +24,5 @@
   @for @ember/helper
   @since 1.13.0
 */
+
+export {};

packages/@ember/-internals/glimmer/lib/helpers/fn.ts

@@ -69,3 +69,5 @@
   @public
   @since 3.11.0
 */
+
+export {};

packages/@ember/-internals/glimmer/lib/helpers/get.ts

@@ -96,3 +96,5 @@
   @for @ember/helper
   @since 2.1.0
  */
+
+export {};

packages/@ember/-internals/glimmer/lib/helpers/hash.ts

@@ -40,3 +40,4 @@
    @since 2.3.0
    @public
  */
+export {};

packages/@ember/-internals/glimmer/lib/helpers/helper.ts

@@ -39,3 +39,4 @@
  @public
  @since 3.27.0
  */
+export {};

packages/@ember/-internals/glimmer/lib/helpers/if-unless.ts

@@ -179,3 +179,5 @@
   @for Ember.Templates.helpers
   @public
 */
+
+export {};

packages/@ember/-internals/glimmer/lib/helpers/log.ts

@@ -15,3 +15,5 @@
   @param {Array} params
   @public
 */
+
+export {};

packages/@ember/-internals/glimmer/lib/helpers/modifier.ts

@@ -38,3 +38,5 @@
  @public
  @since 3.27.0
  */
+
+export {};

packages/@ember/-internals/glimmer/lib/helpers/page-title.ts

@@ -16,3 +16,5 @@
   @param {String} param
   @public
 */
+
+export {};

packages/@ember/-internals/glimmer/lib/modifiers/on.ts

@@ -91,3 +91,5 @@
   @public
   @since 3.11.0
 */
+
+export {};

packages/@ember/-internals/glimmer/lib/syntax/in-element.ts

@@ -43,3 +43,5 @@
  @for Ember.Templates.helpers
  @public
  */
+
+export {};

packages/@ember/-internals/glimmer/lib/syntax/let.ts

@@ -51,3 +51,5 @@
   @for Ember.Templates.helpers
   @public
 */
+
+export {};

packages/@ember/-internals/meta/index.ts

@@ -1 +1 @@
-export { counters, Meta, meta, MetaCounters, peekMeta, setMeta, UNDEFINED } from './lib/meta';
+export { counters, Meta, meta, type MetaCounters, peekMeta, setMeta, UNDEFINED } from './lib/meta';

packages/@ember/-internals/metal/index.ts

@@ -3,11 +3,11 @@ export {
   autoComputed,
   isComputed,
   ComputedProperty,
-  ComputedDecorator,
-  ComputedPropertyGetter,
-  ComputedPropertyObj,
-  ComputedPropertySetter,
-  ComputedPropertyCallback,
+  type ComputedDecorator,
+  type ComputedPropertyGetter,
+  type ComputedPropertyObj,
+  type ComputedPropertySetter,
+  type ComputedPropertyCallback,
 } from './lib/computed';
 export { getCachedValueFor } from './lib/computed_cache';
 export { default as alias } from './lib/alias';
@@ -17,7 +17,7 @@ export {
   _getPath,
   get,
   _getProp,
-  HasUnknownProperty,
+  type HasUnknownProperty,
   hasUnknownProperty,
 } from './lib/property_get';
 export { set, _setProp, trySet } from './lib/property_set';
@@ -37,15 +37,15 @@ export {
   changeProperties,
   endPropertyChanges,
   notifyPropertyChange,
-  PropertyDidChange,
+  type PropertyDidChange,
   PROPERTY_DID_CHANGE,
 } from './lib/property_events';
 export { defineProperty, defineDecorator, defineValue } from './lib/properties';
 export {
-  ExtendedMethodDecorator,
-  DecoratorPropertyDescriptor,
+  type ExtendedMethodDecorator,
+  type DecoratorPropertyDescriptor,
   ComputedDescriptor,
-  ElementDescriptor,
+  type ElementDescriptor,
   isElementDescriptor,
   nativeDescDecorator,
   descriptorForDecorator,

packages/@ember/-internals/metal/lib/dependent_keys.ts

@@ -0,0 +1 @@
+export {};

packages/@ember/owner/index.ts

@@ -33,7 +33,7 @@
 // We need to provide a narrower public interface to `getOwner` so that we only
 // expose the `Owner` type, *not* our richer `InternalOwner` type and its
 // various bits of private API.
-import Owner, { getOwner as internalGetOwner } from '@ember/-internals/owner';
+import { type default as Owner, getOwner as internalGetOwner } from '@ember/-internals/owner';
 
 // NOTE: this documentation appears here instead of at the definition site so
 // it can appear correctly in both API docs and for TS, while providing a richer
@@ -88,15 +88,15 @@ const getOwner = internalGetOwner as (object: object) => Owner | undefined;
 export { getOwner };
 
 // Everything else which is part of the public API, we can directly re-export.
-export default Owner;
+export type { Owner as default };
 
 export {
   setOwner,
-  FullName,
-  RegisterOptions,
-  Factory,
-  FactoryManager,
-  KnownForTypeResult,
-  Resolver,
-  DIRegistry,
+  type FullName,
+  type RegisterOptions,
+  type Factory,
+  type FactoryManager,
+  type KnownForTypeResult,
+  type Resolver,
+  type DIRegistry,
 } from '@ember/-internals/owner';

packages/@ember/routing/-internals.ts

@@ -1,12 +1,12 @@
 export { default as RouterState } from './lib/router_state';
 export { default as RoutingService } from './lib/routing-service';
-export { RouteArgs, prefixRouteNameArg } from './lib/utils';
+export { type RouteArgs, prefixRouteNameArg } from './lib/utils';
 export {
   default as generateController,
   generateControllerFactory,
 } from './lib/generate_controller';
 export { default as BucketCache } from './lib/cache';
-export { default as DSL, DSLCallback } from './lib/dsl';
-export { EngineRouteInfo } from './lib/engines';
-export { RouteInfo, RouteInfoWithAttributes } from './lib/route-info';
+export { default as DSL, type DSLCallback } from './lib/dsl';
+export type { EngineRouteInfo } from './lib/engines';
+export type { RouteInfo, RouteInfoWithAttributes } from './lib/route-info';
 export { default as controllerFor } from './lib/controller_for';

packages/@ember/routing/lib/route-info.ts

@@ -1,4 +1,4 @@
 // Exists to provide runtime exports used in the internals. For the public,
 // type-only exports, see `packages/@ember/routing/route-info`.
 
-export { RouteInfo, RouteInfoWithAttributes } from 'router_js';
+export type { RouteInfo, RouteInfoWithAttributes } from 'router_js';

packages/@ember/routing/router-service.ts

@@ -10,7 +10,7 @@ import { consumeTag, tagFor } from '@glimmer/validator';
 import type { ModelFor, Transition } from 'router_js';
 import type Route from '@ember/routing/route';
 import EmberRouter from '@ember/routing/router';
-import { RouteInfo, RouteInfoWithAttributes } from '@ember/routing/-internals';
+import type { RouteInfo, RouteInfoWithAttributes } from '@ember/routing/-internals';
 import type { RouteArgs, RouteOptions } from './lib/utils';
 import { extractRouteArgs, resemblesURL, shallowEqual } from './lib/utils';
 
@@ -751,4 +751,4 @@ class RouterService extends Service.extend(Evented) {
   declare readonly currentRoute: this['_router']['currentRoute'];
 }
 
-export { RouterService as default, RouteInfo, RouteInfoWithAttributes };
+export { RouterService as default, type RouteInfo, type RouteInfoWithAttributes };

packages/@ember/runloop/-private/backburner.ts

@@ -12,5 +12,5 @@ import type Backburner from 'backburner.js';
 export type { Backburner };
 export type DebugInfo = ReturnType<Backburner['getDebugInfo']>;
 
-export { IQueueItem as QueueItem } from 'backburner.js/dist/backburner/interfaces';
-export { DeferredActionQueues } from 'backburner.js';
+export type { IQueueItem as QueueItem } from 'backburner.js/dist/backburner/interfaces';
+export type { DeferredActionQueues } from 'backburner.js';

packages/@ember/runloop/index.ts

@@ -1,10 +1,10 @@
 import { assert } from '@ember/debug';
 import { onErrorTarget } from '@ember/-internals/error-handling';
 import { flushAsyncObservers } from '@ember/-internals/metal';
-import Backburner, { Timer, type DeferredActionQueues } from 'backburner.js';
+import Backburner, { type Timer, type DeferredActionQueues } from 'backburner.js';
 import type { AnyFn } from '@ember/-internals/utility-types';
 
-export { Timer };
+export type { Timer };
 
 // Partial types from https://medium.com/codex/currying-in-typescript-ca5226c85b85
 

packages/@ember/test/adapter.ts

@@ -1,3 +1 @@
-import { Adapter } from 'ember-testing';
-
-export default Adapter;
+export { Adapter as default } from 'ember-testing';

packages/ember-template-compiler/lib/public-api.ts

@@ -11,7 +11,7 @@ export {
   transformsFor as _transformsFor,
 } from './system/compile-options';
 export { RESOLUTION_MODE_TRANSFORMS, STRICT_MODE_TRANSFORMS } from './plugins';
-export { EmberPrecompileOptions } from './types';
+export type { EmberPrecompileOptions } from './types';
 
 export { preprocess as _preprocess, print as _print } from '@glimmer/syntax';
 export { precompile as _precompile } from '@glimmer/compiler';

pnpm-lock.yaml

@@ -21,6 +21,7 @@
     "noUnusedParameters": true,
     "esModuleInterop": false,
     "allowSyntheticDefaultImports": false,
+    "isolatedModules": true,
 
     "newLine": "LF",