Skip to content

Test example does not compile #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martincarles opened this issue Dec 10, 2018 · 5 comments
Closed

Test example does not compile #25

martincarles opened this issue Dec 10, 2018 · 5 comments
Labels

Comments

@martincarles
Copy link

martincarles commented Dec 10, 2018

Hi @eddow, thanks for your work on this library. Much appreciated.
We're trying to use it in our projects but we keep getting the "Dynamic golden-layout components should be named templates instead" message.
Could you please provide some working examples of templates and names slots working together?
The test example you provide doesn't compile.

Thanks in advance!

@eddow
Copy link
Collaborator

eddow commented Dec 10, 2018

Hello,

Then the issue is that the test example does not compile :) Could you please provide the compilation errors so we could solve it ?

@eddow eddow added the bug label Dec 10, 2018
@martincarles martincarles changed the title Provide examples with templates and named slots Test example does not compile Dec 10, 2018
@martincarles
Copy link
Author

Hello, yes sorry. I just updated the title.
Here is the error message I'm getting.
The only thing I did was cloning the repo, running npm install and then npm test.

image

@eddow
Copy link
Collaborator

eddow commented Dec 10, 2018

Damn... I can't reproduce ... O.o
I'm searching blindly what it could be but I am still lost....
Do you have the last version ? I mean, did you just clone?
EDIT: I just saw it's about the Component decorator - I keep on looking but it's not a question of version

@eddow
Copy link
Collaborator

eddow commented Dec 10, 2018

So,
The bug comes indeed from a library used here (an issue has been opened)

Beside, I changed the status of a function (from global to exported), it should do the job.

Could you please pull the last version and confirm nothing else breaks the test application ?

@eddow
Copy link
Collaborator

eddow commented Dec 10, 2018

@martincarles I will close it for now - please feel free to re-open if something is still wrong.

@eddow eddow closed this as completed Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants