Skip to content

Commit 59e6b8f

Browse files
authored
[test] Simplify new KeyboardEvent calls in test_browser.py. NFC (#21351)
Closure knows about these property bags so there is no need to quote the keys.
1 parent ee97739 commit 59e6b8f

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

test/test_browser.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -923,14 +923,14 @@ def test_sdl_key(self, delay, async_, defines):
923923
create_file('pre.js', '''
924924
function keydown(c) {
925925
%s
926-
var event = new KeyboardEvent("keydown", { 'keyCode': c, 'charCode': c, 'view': window, 'bubbles': true, 'cancelable': true });
926+
var event = new KeyboardEvent('keydown', { keyCode: c, charCode: c, view: window, bubbles: true, cancelable: true });
927927
document.dispatchEvent(event);
928928
%s
929929
}
930930
931931
function keyup(c) {
932932
%s
933-
var event = new KeyboardEvent("keyup", { 'keyCode': c, 'charCode': c, 'view': window, 'bubbles': true, 'cancelable': true });
933+
var event = new KeyboardEvent('keyup', { keyCode: c, charCode: c, view: window, bubbles: true, cancelable: true });
934934
document.dispatchEvent(event);
935935
%s
936936
}
@@ -953,12 +953,12 @@ def post():
953953
html = html.replace('</body>', '''
954954
<script>
955955
function keydown(c) {
956-
var event = new KeyboardEvent("keydown", { 'keyCode': c, 'charCode': c, 'view': window, 'bubbles': true, 'cancelable': true });
956+
var event = new KeyboardEvent('keydown', { keyCode: c, charCode: c, view: window, bubbles: true, cancelable: true });
957957
document.dispatchEvent(event);
958958
}
959959
960960
function keyup(c) {
961-
var event = new KeyboardEvent("keyup", { 'keyCode': c, 'charCode': c, 'view': window, 'bubbles': true, 'cancelable': true });
961+
var event = new KeyboardEvent('keyup', { keyCode: c, charCode: c, view: window, bubbles: true, cancelable: true });
962962
document.dispatchEvent(event);
963963
}
964964
@@ -985,17 +985,17 @@ def post():
985985
html = html.replace('</body>', '''
986986
<script>
987987
function keydown(c) {
988-
var event = new KeyboardEvent("keydown", { 'keyCode': c, 'charCode': c, 'view': window, 'bubbles': true, 'cancelable': true });
988+
var event = new KeyboardEvent('keydown', { keyCode: c, charCode: c, view: window, bubbles: true, cancelable: true });
989989
return document.dispatchEvent(event);
990990
}
991991
992992
function keypress(c) {
993-
var event = new KeyboardEvent("keypress", { 'keyCode': c, 'charCode': c, 'view': window, 'bubbles': true, 'cancelable': true });
993+
var event = new KeyboardEvent('keypress', { keyCode: c, charCode: c, view: window, bubbles: true, cancelable: true });
994994
return document.dispatchEvent(event);
995995
}
996996
997997
function keyup(c) {
998-
var event = new KeyboardEvent("keyup", { 'keyCode': c, 'charCode': c, 'view': window, 'bubbles': true, 'cancelable': true });
998+
var event = new KeyboardEvent('keyup', { keyCode: c, charCode: c, view: window, bubbles: true, cancelable: true });
999999
return document.dispatchEvent(event);
10001000
}
10011001
@@ -1037,7 +1037,7 @@ def test_sdl_text(self):
10371037
}
10381038
10391039
function simulateKeyEvent(c) {
1040-
var event = new KeyboardEvent("keypress", { 'keyCode': c, 'charCode': c, 'view': window, 'bubbles': true, 'cancelable': true });
1040+
var event = new KeyboardEvent('keypress', { keyCode: c, charCode: c, view: window, bubbles: true, cancelable: true });
10411041
document.body.dispatchEvent(event);
10421042
}
10431043
''')
@@ -1535,7 +1535,7 @@ def test_sdl_pumpevents(self):
15351535
# key events should be detected using SDL_PumpEvents
15361536
create_file('pre.js', '''
15371537
function keydown(c) {
1538-
var event = new KeyboardEvent("keydown", { 'keyCode': c, 'charCode': c, 'view': window, 'bubbles': true, 'cancelable': true });
1538+
var event = new KeyboardEvent('keydown', { keyCode: c, charCode: c, view: window, bubbles: true, cancelable: true });
15391539
document.dispatchEvent(event);
15401540
}
15411541
''')
@@ -3055,18 +3055,18 @@ def test_sdl2_image_formats(self):
30553055
def test_sdl2_key(self):
30563056
create_file('pre.js', '''
30573057
function keydown(keyCode, code) {
3058-
var event = new KeyboardEvent("keydown", { keyCode, code, charCode: keyCode, 'view': window, 'bubbles': true, 'cancelable': true });
3058+
var event = new KeyboardEvent('keydown', { keyCode, code, charCode: keyCode, view: window, bubbles: true, cancelable: true });
30593059
var prevented = !document.dispatchEvent(event);
30603060
30613061
//send keypress if not prevented
30623062
if (!prevented) {
3063-
var event = new KeyboardEvent("keypress", { keyCode, code, charCode: keyCode, 'view': window, 'bubbles': true, 'cancelable': true });
3063+
var event = new KeyboardEvent('keypress', { keyCode, code, charCode: keyCode, view: window, bubbles: true, cancelable: true });
30643064
document.dispatchEvent(event);
30653065
}
30663066
}
30673067
30683068
function keyup(keyCode, code) {
3069-
var event = new KeyboardEvent("keyup", { keyCode, code, charCode: keyCode, 'view': window, 'bubbles': true, 'cancelable': true });
3069+
var event = new KeyboardEvent('keyup', { keyCode, code, charCode: keyCode, view: window, bubbles: true, cancelable: true });
30703070
document.dispatchEvent(event);
30713071
}
30723072
''')
@@ -3085,7 +3085,7 @@ def test_sdl2_text(self):
30853085
}
30863086
30873087
function simulateKeyEvent(c) {
3088-
var event = new KeyboardEvent("keypress", { 'keyCode': c, 'charCode': c, 'view': window, 'bubbles': true, 'cancelable': true });
3088+
var event = new KeyboardEvent('keypress', { keyCode: c, charCode: c, view: window, bubbles: true, cancelable: true });
30893089
document.body.dispatchEvent(event);
30903090
}
30913091
''')
@@ -3282,7 +3282,7 @@ def test_sdl2_pumpevents(self):
32823282
# key events should be detected using SDL_PumpEvents
32833283
create_file('pre.js', '''
32843284
function keydown(keyCode, code) {
3285-
var event = new KeyboardEvent("keydown", { keyCode, code, charCode: keyCode, 'view': window, 'bubbles': true, 'cancelable': true });
3285+
var event = new KeyboardEvent('keydown', { keyCode, code, charCode: keyCode, view: window, bubbles: true, cancelable: true });
32863286
document.dispatchEvent(event);
32873287
}
32883288
''')

0 commit comments

Comments
 (0)