Skip to content

Commit b256af6

Browse files
committed
disable asm2m for now, due to windows breakage #3326
1 parent 10f7afc commit b256af6

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

src/settings.js

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ var MEM_INIT_METHOD = 0; // How to represent the initial memory content.
4040
// 1: create a *.mem file containing the binary data of the initial memory;
4141
// use the --memory-init-file command line switch to select this method
4242
// 2: embed a string literal representing that initial memory data
43+
// XXX this is known to have bugs on windows, see https://github.com/kripken/emscripten/pull/3326
4344
var TOTAL_STACK = 5*1024*1024; // The total stack size. There is no way to enlarge the stack, so this
4445
// value must be large enough for the program's requirements. If
4546
// assertions are on, we will assert on not exceeding this, otherwise,

tests/parallel_test_core.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
assert not os.environ.get('EM_SAVE_DIR'), 'Need separate directories to avoid the parallel tests clashing'
1515

1616
# run slower ones first, to optimize total time
17-
optimal_order = ['asm3i', 'asm1i', 'asm2nn', 'asm3', 'asm2', 'asm2m', 'asm2g', 'asm2f', 'asm1', 'default']
17+
optimal_order = ['asm3i', 'asm1i', 'asm2nn', 'asm3', 'asm2', 'asm2g', 'asm2f', 'asm1', 'default']
1818
assert set(optimal_order) == set(test_modes), 'need to update the list of slowest modes'
1919

2020
# set up a background thread to report progress

tests/runner.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def path_from_root(*pathelems):
3838

3939
# Core test runner class, shared between normal tests and benchmarks
4040
checked_sanity = False
41-
test_modes = ['default', 'asm1', 'asm2', 'asm3', 'asm2f', 'asm2g', 'asm1i', 'asm3i', 'asm2m', 'asm2nn']
41+
test_modes = ['default', 'asm1', 'asm2', 'asm3', 'asm2f', 'asm2g', 'asm1i', 'asm3i', 'asm2nn']
4242
test_index = 0
4343

4444
use_all_engines = os.environ.get('EM_ALL_ENGINES') # generally js engines are equivalent, testing 1 is enough. set this

tests/test_core.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -7449,7 +7449,7 @@ def setUp(self):
74497449
asm2g = make_run("asm2g", compiler=CLANG, emcc_args=["-O2", "-g", "-s", "ASSERTIONS=1", "-s", "SAFE_HEAP=1"])
74507450
asm1i = make_run("asm1i", compiler=CLANG, emcc_args=["-O1", '-s', 'EMTERPRETIFY=1'])
74517451
asm3i = make_run("asm3i", compiler=CLANG, emcc_args=["-O3", '-s', 'EMTERPRETIFY=1'])
7452-
asm2m = make_run("asm2m", compiler=CLANG, emcc_args=["-O2", "--memory-init-file", "0", "-s", "MEM_INIT_METHOD=2", "-s", "ASSERTIONS=1"])
7452+
#asm2m = make_run("asm2m", compiler=CLANG, emcc_args=["-O2", "--memory-init-file", "0", "-s", "MEM_INIT_METHOD=2", "-s", "ASSERTIONS=1"])
74537453

74547454
# Legacy test modes -
74557455
asm2nn = make_run("asm2nn", compiler=CLANG, emcc_args=["-O2"], env={"EMCC_NATIVE_OPTIMIZER": "0"})

0 commit comments

Comments
 (0)