Remove second argument to ErrnoError. NFC (#21136)

There was only one single place (out of hundreds) where this was set
and one single place in `doStat` where it was read.

I removed the `doStat` workaround by updating `mayLookup` instead.

Author: sbc100

src/library_fs.js

@@ -231,7 +231,7 @@ FS.staticInit();` +
     lookupNode(parent, name) {
       var errCode = FS.mayLookup(parent);
       if (errCode) {
-        throw new FS.ErrnoError(errCode, parent);
+        throw new FS.ErrnoError(errCode);
       }
       var hash = FS.hashName(parent.id, name);
 #if CASE_INSENSITIVE_FS
@@ -316,6 +316,7 @@ FS.staticInit();` +
       return 0;
     },
     mayLookup(dir) {
+      if (!FS.isDir(dir.mode)) return {{{ cDefs.ENOTDIR }}};
       var errCode = FS.nodePermissions(dir, 'x');
       if (errCode) return errCode;
       if (!dir.node_ops.lookup) return {{{ cDefs.EACCES }}};
@@ -1408,15 +1409,14 @@ FS.staticInit();` +
     },
     ensureErrnoError() {
       if (FS.ErrnoError) return;
-      FS.ErrnoError = /** @this{Object} */ function ErrnoError(errno, node) {
+      FS.ErrnoError = /** @this{Object} */ function ErrnoError(errno) {
         // We set the `name` property to be able to identify `FS.ErrnoError`
         // - the `name` is a standard ECMA-262 property of error objects. Kind of good to have it anyway.
         // - when using PROXYFS, an error can come from an underlying FS
         // as different FS objects have their own FS.ErrnoError each,
         // the test `err instanceof FS.ErrnoError` won't detect an error coming from another filesystem, causing bugs.
         // we'll use the reliable test `err.name == "ErrnoError"` instead
         this.name = 'ErrnoError';
-        this.node = node;
         this.setErrno = /** @this{Object} */ function(errno) {
           this.errno = errno;
 #if ASSERTIONS

src/library_syscall.js

@@ -42,15 +42,7 @@ var SyscallsLibrary = {
     },
 
     doStat(func, path, buf) {
-      try {
-        var stat = func(path);
-      } catch (e) {
-        if (e && e.node && PATH.normalize(path) !== PATH.normalize(FS.getPath(e.node))) {
-          // an error occurred while trying to look up the path; we should just report ENOTDIR
-          return -{{{ cDefs.ENOTDIR }}};
-        }
-        throw e;
-      }
+      var stat = func(path);
       {{{ makeSetValue('buf', C_STRUCTS.stat.st_dev, 'stat.dev', 'i32') }}};
       {{{ makeSetValue('buf', C_STRUCTS.stat.st_mode, 'stat.mode', 'i32') }}};
       {{{ makeSetValue('buf', C_STRUCTS.stat.st_nlink, 'stat.nlink', SIZE_TYPE) }}};

test/other/metadce/test_metadce_cxx_ctors1.gzsize

@@ -1 +1 @@
-9936
+9932

test/other/metadce/test_metadce_cxx_ctors1.jssize

@@ -1 +1 @@
-24683
+24693

test/other/metadce/test_metadce_cxx_ctors2.gzsize

@@ -1 +1 @@
-9921
+9915

test/other/metadce/test_metadce_cxx_ctors2.jssize

@@ -1 +1 @@
-24651
+24661

test/other/metadce/test_metadce_cxx_except.gzsize

@@ -1 +1 @@
-11015
+11010

test/other/metadce/test_metadce_cxx_except.jssize

@@ -1 +1 @@
-28573
+28583

test/other/metadce/test_metadce_cxx_except_wasm.gzsize

@@ -1 +1 @@
-9903
+9899

test/other/metadce/test_metadce_cxx_except_wasm.jssize

@@ -1 +1 @@
-24576
+24586

test/other/metadce/test_metadce_cxx_mangle.gzsize

@@ -1 +1 @@
-11021
+11016

test/other/metadce/test_metadce_cxx_mangle.jssize

@@ -1 +1 @@
-28573
+28583

test/other/metadce/test_metadce_cxx_noexcept.gzsize

@@ -1 +1 @@
-9936
+9932

test/other/metadce/test_metadce_cxx_noexcept.jssize

@@ -1 +1 @@
-24683
+24693

test/other/metadce/test_metadce_files_js_fs.gzsize

@@ -1 +1 @@
-7874
+7871

test/other/metadce/test_metadce_files_js_fs.jssize

@@ -1 +1 @@
-19705
+19715