Skip to content

Commit e183168

Browse files
committed
Remove no_wasm_backend usage from test_core.py
The only remaining usage is in test_browser.py.
1 parent 47dc32a commit e183168

File tree

11 files changed

+32
-625
lines changed

11 files changed

+32
-625
lines changed

tests/core/test_intentional_fault.c

Lines changed: 0 additions & 12 deletions
This file was deleted.

tests/core/test_llvm_intrinsics.cpp

Lines changed: 0 additions & 198 deletions
This file was deleted.

tests/core/test_lower_intrinsics.c

Lines changed: 0 additions & 35 deletions
This file was deleted.

tests/core/test_varargs_multi.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,18 @@ void print_vararg(int n, va_list v) {
2121
void multi_vararg(int n, ...) {
2222
va_list v;
2323

24+
printf("part1:\n");
2425
va_start(v, n);
2526
print_vararg(n, v);
26-
print_vararg(n, v); // the value of v is undefined for this call
2727
va_end(v);
2828

29+
printf("part2:\n");
2930
va_start(v, n);
3031
print_vararg(n, v);
32+
printf("part3:\n");
33+
print_vararg(n, v); // the value of v is undefined for this call
3134
va_end(v);
35+
3236
}
3337

3438
int main() {

tests/core/test_varargs_multi.out

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
part1:
2+
8, 6, 4, 2, 0
3+
part2:
4+
8, 6, 4, 2, 0
5+
part3:
16
8, 6, 4, 2, 0
2-
1, 3, 5, 7, 9
3-
8, 6, 4, 2, 0

tests/runner.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -151,14 +151,6 @@ def decorated(self, *args, **kwargs):
151151
return decorated
152152

153153

154-
# Today we only support the wasm backend so any tests that is disabled under the llvm
155-
# backend is always disabled.
156-
# TODO(sbc): Investigate all tests with this decorator and either fix of remove the test.
157-
def no_wasm_backend(note=''):
158-
assert not callable(note)
159-
return unittest.skip(note)
160-
161-
162154
def disabled(note=''):
163155
assert not callable(note)
164156
return unittest.skip(note)

tests/test_browser.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from urllib.request import urlopen
2222

2323
from runner import BrowserCore, RunnerCore, path_from_root, has_browser, EMTEST_BROWSER
24-
from runner import no_wasm_backend, create_test_file, parameterized, ensure_dir
24+
from runner import create_test_file, parameterized, ensure_dir
2525
from tools import building
2626
from tools import shared
2727
from tools import system_libs
@@ -126,6 +126,14 @@ def decorated(self, *args, **kwargs):
126126
return decorated
127127

128128

129+
# Today we only support the wasm backend so any tests that is disabled under the llvm
130+
# backend is always disabled.
131+
# TODO(sbc): Investigate all tests with this decorator and either fix of remove the test.
132+
def no_wasm_backend(note=''):
133+
assert not callable(note)
134+
return unittest.skip(note)
135+
136+
129137
requires_graphics_hardware = unittest.skipIf(os.getenv('EMTEST_LACKS_GRAPHICS_HARDWARE'), "This test requires graphics hardware")
130138
requires_sound_hardware = unittest.skipIf(os.getenv('EMTEST_LACKS_SOUND_HARDWARE'), "This test requires sound hardware")
131139
requires_sync_compilation = unittest.skipIf(is_chrome(), "This test requires synchronous compilation, which does not work in Chrome (except for tiny wasms)")

0 commit comments

Comments
 (0)