Skip to content

Commit ce59d6d

Browse files
committed
Update after #530
1 parent 377cc5b commit ce59d6d

File tree

3 files changed

+19
-13
lines changed

3 files changed

+19
-13
lines changed

.circleci/config.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,9 @@ jobs:
9191
python scripts/test.py
9292
9393
build-docker-image:
94-
executor: bionic
94+
machine: true # required for testing files permissions
9595
steps:
9696
- checkout
97-
- run:
98-
name: install docker
99-
command: apt-get update -q && apt-get install -q -y docker.io
100-
- setup_remote_docker
10197
# build and test the latest released version of EMSDK
10298
- run:
10399
name: build

docker/Makefile

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/env make
22

33
# Emscripten version to build: Should match the version that has been already released.
4-
# i.e.: 1.38.45, 1.38.45-upstream
4+
# i.e.: 1.39.18
55
version =
66
alias =
77

@@ -11,21 +11,32 @@ ifndef version
1111
endif
1212

1313
build: .TEST
14-
docker build --network host --build-arg=EMSCRIPTEN_VERSION=${version}-upstream --tag emscripten/emsdk:${version} .
14+
docker build --network host --build-arg=EMSCRIPTEN_VERSION=${version} --tag emscripten/emsdk:${version} .
1515

1616
test: .TEST
17-
# compilation without root
18-
docker run --rm -u 1000:1000 -v `pwd`:/src -w /src emscripten/emsdk:${version} emcc -c main.c -o main
17+
# compilation as non-root
18+
docker run --rm -u 1000:1000 -v `pwd`:/src -w /src emscripten/emsdk:${version} \
19+
bash -c "\
20+
mkdir -p .test \
21+
&& echo 'int main() { return 0; }' > .test/main.c \
22+
&& emcc -c .test/main.c -o .test/main\
23+
"
1924
# artifact should be removable from host by non-root
20-
rm -fr main
25+
rm -fr .test
2126

2227
# running as non-root and forcing downloading ports
2328
docker run --rm -u 1000:1000 --net=host emscripten/emsdk:${version} embuilder build zlib
2429

2530
# compilation without entrypoint
26-
docker run --rm -e /bin/bash -v `pwd`:/src -w /src emscripten/emsdk:${version} emcc -c main.c -o main
31+
docker run --rm -e /bin/bash -v `pwd`:/src -w /src emscripten/emsdk:${version} \
32+
bash -c "\
33+
mkdir -p .test \
34+
&& echo 'int main() { return 0; }' > .test/main.c \
35+
&& emcc -c .test/main.c -o .test/main\
36+
"
37+
2738
# artifact should be removable from host by non-root
28-
rm -fr main
39+
rm -fr .test
2940

3041
push: .TEST
3142
docker push emscripten/emsdk:${version}

docker/main.c

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)