Skip to content

Commit eff1d2e

Browse files
authored
Drop "-upstream" suffix from docker image name (#530)
1 parent 47c669a commit eff1d2e

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ jobs:
112112
- setup_remote_docker
113113
- run:
114114
name: build
115-
command: docker build --network host --build-arg=EMSCRIPTEN_VERSION=${CIRCLE_TAG}-upstream --tag emscripten/emsdk:${CIRCLE_TAG} ./docker
115+
command: docker build --network host --build-arg EMSCRIPTEN_VERSION=${CIRCLE_TAG} --tag emscripten/emsdk:${CIRCLE_TAG} ./docker
116116
- run:
117117
name: tag image
118118
command: docker tag emscripten/emsdk:${CIRCLE_TAG} emscripten/emsdk:latest

docker/Dockerfile

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
FROM debian:buster AS stage_build
22

3-
# ------------------------------------------------------------------------------
4-
5-
# Supports only 1.38.40+, accepts also '-upstream' variants
63
ARG EMSCRIPTEN_VERSION=1.39.18
7-
8-
# ------------------------------------------------------------------------------
9-
104
ENV EMSDK /emsdk
115

126
# ------------------------------------------------------------------------------
@@ -52,9 +46,10 @@ RUN echo "## Aggresive optimization: Remove debug symbols" \
5246
&& strip -s `which node` \
5347
# Tests consume ~80MB disc space
5448
&& rm -fr ${EMSDK}/upstream/emscripten/tests \
49+
# Fastcomp is not supported
50+
&& rm -fr ${EMSDK}/upstream/fastcomp \
5551
# strip out symbols from clang (~extra 50MB disc space)
5652
&& find ${EMSDK}/upstream/bin -type f -exec strip -s {} + || true \
57-
&& find ${EMSDK}/upstream/fastcomp/bin -type f -exec strip -s {} + || true \
5853
&& echo "## Done"
5954

6055
# Generate sanity

0 commit comments

Comments
 (0)