Skip to content

Commit 2309bcc

Browse files
author
Harry Terkelsen
authored
Add WASM target in gn (flutter#31670)
1 parent 81547d1 commit 2309bcc

File tree

13 files changed

+329
-82
lines changed

13 files changed

+329
-82
lines changed

BUILD.gn

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,14 @@ config("export_dynamic_symbols") {
3131
}
3232
}
3333

34+
# Flutter SDK artifacts should only be built when either doing host builds, or
35+
# for cross-compiled desktop targets.
36+
# TODO: We can't build the engine artifacts for arm (32-bit) right now;
37+
# see https://github.com/flutter/flutter/issues/74322
38+
_build_engine_artifacts =
39+
current_toolchain == host_toolchain ||
40+
(is_linux && !is_chromeos && current_cpu != "arm") || is_mac
41+
3442
if (flutter_prebuilt_dart_sdk) {
3543
copy_trees("_copy_trees") {
3644
sources = [
@@ -45,14 +53,6 @@ if (flutter_prebuilt_dart_sdk) {
4553
}
4654
}
4755

48-
# Flutter SDK artifacts should only be built when either doing host builds, or
49-
# for cross-compiled desktop targets.
50-
# TODO: We can't build the engine artifacts for arm (32-bit) right now;
51-
# see https://github.com/flutter/flutter/issues/74322
52-
_build_engine_artifacts =
53-
current_toolchain == host_toolchain ||
54-
(is_linux && !is_chromeos && current_cpu != "arm") || is_mac
55-
5656
group("dart_sdk") {
5757
if (build_engine_artifacts) {
5858
if (flutter_prebuilt_dart_sdk) {

DEPS

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,12 @@ vars = {
3333
# See `lib/web_ui/README.md` for how to roll CanvasKit to a new version.
3434
'canvaskit_cipd_instance': '8MSYGWVWzrTJIoVL00ZquruZs-weuwLBy1kt1AawJiIC',
3535

36+
# Do not download the Emscripten SDK by default.
37+
# This prevents us from downloading the Emscripten toolchain for builds
38+
# which do not build for the web. This toolchain is needed to build CanvasKit
39+
# for the web engine.
40+
'download_emsdk': False,
41+
3642
# When updating the Dart revision, ensure that all entries that are
3743
# dependencies of Dart are also updated to match the entries in the
3844
# Dart SDK's DEPS file for that revision of Dart. The DEPS file for
@@ -155,7 +161,7 @@ deps = {
155161
# Chromium-style dependencies.
156162

157163
'src/third_party/icu':
158-
Var('chromium_git') + '/chromium/deps/icu.git' + '@' + '2e0f2989441ec2f55abec30f48e89981dbac2c34',
164+
Var('chromium_git') + '/chromium/deps/icu.git' + '@' + '1fa4e3959ec6637182b7318ac1d382799454806d',
159165

160166
'src/third_party/khronos':
161167
Var('chromium_git') + '/chromium/src/third_party/khronos.git' + '@' + '7122230e90547962e0f0c627f62eeed3c701f275',
@@ -565,6 +571,11 @@ deps = {
565571
'dep_type': 'cipd',
566572
},
567573

574+
'src/buildtools/emsdk': {
575+
'url': Var('skia_git') + '/external/github.com/emscripten-core/emsdk.git' + '@' + 'fc645b7626ebf86530dbd82fbece74d457e7ae07',
576+
'condition': 'download_emsdk',
577+
},
578+
568579
# Clang on mac and linux are expected to typically be the same revision.
569580
# They are separated out so that the autoroller can more easily manage them.
570581
'src/buildtools/mac-x64/clang': {
@@ -739,6 +750,15 @@ hooks = [
739750
Var('fuchsia_sdk_path'),
740751
]
741752
},
753+
{
754+
'name': 'Activate Emscripten SDK',
755+
'pattern': '.',
756+
'condition': 'download_emsdk',
757+
'action': [
758+
'python3',
759+
'src/flutter/tools/activate_emsdk.py',
760+
]
761+
},
742762
{
743763
'name': 'Setup githooks',
744764
'pattern': '.',

ci/licenses_golden/licenses_skia

Lines changed: 40 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -651,8 +651,17 @@ FILE: ../../../third_party/skia/BUILD.bazel
651651
FILE: ../../../third_party/skia/CQ_COMMITTERS
652652
FILE: ../../../third_party/skia/DEPS
653653
FILE: ../../../third_party/skia/DIR_METADATA
654-
FILE: ../../../third_party/skia/OWNERS.android
655654
FILE: ../../../third_party/skia/WORKSPACE.bazel
655+
FILE: ../../../third_party/skia/animations/checkbox.xml
656+
FILE: ../../../third_party/skia/animations/chest#1.jpg
657+
FILE: ../../../third_party/skia/animations/fire#1.jpg
658+
FILE: ../../../third_party/skia/animations/images#1.xml
659+
FILE: ../../../third_party/skia/animations/jet#1.jpg
660+
FILE: ../../../third_party/skia/animations/lines#1.xml
661+
FILE: ../../../third_party/skia/animations/movie#1.xml
662+
FILE: ../../../third_party/skia/animations/paths#1.xml
663+
FILE: ../../../third_party/skia/animations/redcross#1.jpg
664+
FILE: ../../../third_party/skia/animations/text#1.xml
656665
FILE: ../../../third_party/skia/bazel/BUILD.bazel
657666
FILE: ../../../third_party/skia/bazel/cc_binary_with_flags.bzl
658667
FILE: ../../../third_party/skia/bazel/common_config_settings/BUILD.bazel
@@ -754,6 +763,16 @@ FILE: ../../../third_party/skia/experimental/tskit/package.json
754763
FILE: ../../../third_party/skia/experimental/tskit/tsconfig.json
755764
FILE: ../../../third_party/skia/experimental/wasm-hello-world/BUILD.bazel
756765
FILE: ../../../third_party/skia/experimental/wasm-hello-world/hello_world.html
766+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/cpu.js
767+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/debugger/anim.mskp
768+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/debugger/index.html
769+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/debugger/sample.skp
770+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/externs.js
771+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/fonts/NotoMono-Regular.ttf
772+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/gpu.js
773+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/helper.js
774+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/karma.conf.js
775+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/package.json
757776
FILE: ../../../third_party/skia/experimental/webgpu-bazel/example/index.html
758777
FILE: ../../../third_party/skia/experimental/webgpu-bazel/src/BUILD
759778
FILE: ../../../third_party/skia/gm/BUILD.bazel
@@ -784,7 +803,6 @@ FILE: ../../../third_party/skia/include/private/BUILD.bazel
784803
FILE: ../../../third_party/skia/include/private/chromium/BUILD.bazel
785804
FILE: ../../../third_party/skia/include/sksl/BUILD.bazel
786805
FILE: ../../../third_party/skia/include/svg/BUILD.bazel
787-
FILE: ../../../third_party/skia/include/third_party/BUILD.bazel
788806
FILE: ../../../third_party/skia/include/utils/BUILD.bazel
789807
FILE: ../../../third_party/skia/include/utils/mac/BUILD.bazel
790808
FILE: ../../../third_party/skia/infra/bots/BUILD.bazel
@@ -1893,6 +1911,7 @@ FILE: ../../../third_party/skia/bench/StreamBench.cpp
18931911
FILE: ../../../third_party/skia/bench/SwizzleBench.cpp
18941912
FILE: ../../../third_party/skia/bench/TileImageFilterBench.cpp
18951913
FILE: ../../../third_party/skia/bench/VertexColorSpaceBench.cpp
1914+
FILE: ../../../third_party/skia/experimental/xps_to_png/xps_to_png.cs
18961915
FILE: ../../../third_party/skia/fuzz/Fuzz.cpp
18971916
FILE: ../../../third_party/skia/fuzz/Fuzz.h
18981917
FILE: ../../../third_party/skia/fuzz/FuzzGradients.cpp
@@ -3247,7 +3266,7 @@ FILE: ../../../third_party/skia/src/effects/imagefilters/SkComposeImageFilter.cp
32473266
FILE: ../../../third_party/skia/src/effects/imagefilters/SkDisplacementMapImageFilter.cpp
32483267
FILE: ../../../third_party/skia/src/effects/imagefilters/SkDropShadowImageFilter.cpp
32493268
FILE: ../../../third_party/skia/src/effects/imagefilters/SkTileImageFilter.cpp
3250-
FILE: ../../../third_party/skia/src/gpu/Blend.h
3269+
FILE: ../../../third_party/skia/src/gpu/GrBlend.h
32513270
FILE: ../../../third_party/skia/src/gpu/GrCaps.h
32523271
FILE: ../../../third_party/skia/src/gpu/GrGeometryProcessor.h
32533272
FILE: ../../../third_party/skia/src/gpu/GrPaint.cpp
@@ -3326,6 +3345,7 @@ TYPE: LicenseType.bsd
33263345
FILE: ../../../third_party/skia/bench/BulkRectBench.cpp
33273346
FILE: ../../../third_party/skia/bench/DDLRecorderBench.cpp
33283347
FILE: ../../../third_party/skia/bench/SkSLBench.cpp
3348+
FILE: ../../../third_party/skia/experimental/wasm-skp-debugger/debugger_bindings.cpp
33293349
FILE: ../../../third_party/skia/gm/asyncrescaleandread.cpp
33303350
FILE: ../../../third_party/skia/gm/crbug_908646.cpp
33313351
FILE: ../../../third_party/skia/gm/crbug_946965.cpp
@@ -3445,6 +3465,7 @@ FILE: ../../../third_party/skia/bench/PathOpsBench.cpp
34453465
FILE: ../../../third_party/skia/bench/PolyUtilsBench.cpp
34463466
FILE: ../../../third_party/skia/bench/ShaderMaskFilterBench.cpp
34473467
FILE: ../../../third_party/skia/bench/TypefaceBench.cpp
3468+
FILE: ../../../third_party/skia/experimental/pvg/draw_msg.proto
34483469
FILE: ../../../third_party/skia/fuzz/FuzzCommon.cpp
34493470
FILE: ../../../third_party/skia/fuzz/FuzzPathMeasure.cpp
34503471
FILE: ../../../third_party/skia/fuzz/FuzzRegionOp.cpp
@@ -4182,6 +4203,21 @@ TYPE: LicenseType.bsd
41824203
FILE: ../../../third_party/skia/bench/FindCubicConvex180ChopsBench.cpp
41834204
FILE: ../../../third_party/skia/bench/GlyphQuadFillBench.cpp
41844205
FILE: ../../../third_party/skia/bench/TessellateBench.cpp
4206+
FILE: ../../../third_party/skia/experimental/skrive/include/SkRive.h
4207+
FILE: ../../../third_party/skia/experimental/skrive/src/Artboard.cpp
4208+
FILE: ../../../third_party/skia/experimental/skrive/src/Color.cpp
4209+
FILE: ../../../third_party/skia/experimental/skrive/src/Component.cpp
4210+
FILE: ../../../third_party/skia/experimental/skrive/src/Drawable.cpp
4211+
FILE: ../../../third_party/skia/experimental/skrive/src/Ellipse.cpp
4212+
FILE: ../../../third_party/skia/experimental/skrive/src/Node.cpp
4213+
FILE: ../../../third_party/skia/experimental/skrive/src/Paint.cpp
4214+
FILE: ../../../third_party/skia/experimental/skrive/src/Rectangle.cpp
4215+
FILE: ../../../third_party/skia/experimental/skrive/src/Shape.cpp
4216+
FILE: ../../../third_party/skia/experimental/skrive/src/SkRive.cpp
4217+
FILE: ../../../third_party/skia/experimental/skrive/src/reader/BinaryReader.cpp
4218+
FILE: ../../../third_party/skia/experimental/skrive/src/reader/JsonReader.cpp
4219+
FILE: ../../../third_party/skia/experimental/skrive/src/reader/StreamReader.cpp
4220+
FILE: ../../../third_party/skia/experimental/skrive/src/reader/StreamReader.h
41854221
FILE: ../../../third_party/skia/fuzz/FuzzSkParagraph.cpp
41864222
FILE: ../../../third_party/skia/gm/3d.cpp
41874223
FILE: ../../../third_party/skia/gm/bc1_transparency.cpp
@@ -6091,8 +6127,6 @@ FILE: ../../../third_party/skia/experimental/graphite/src/UploadTask.h
60916127
FILE: ../../../third_party/skia/experimental/graphite/src/mtl/MtlSampler.h
60926128
FILE: ../../../third_party/skia/experimental/graphite/src/mtl/MtlSampler.mm
60936129
FILE: ../../../third_party/skia/gm/bug12866.cpp
6094-
FILE: ../../../third_party/skia/include/core/SkAlphaType.h
6095-
FILE: ../../../third_party/skia/include/core/SkColorType.h
60966130
FILE: ../../../third_party/skia/include/private/SkUniquePaintParamsID.h
60976131
FILE: ../../../third_party/skia/src/core/SkBuiltInCodeSnippetID.h
60986132
FILE: ../../../third_party/skia/src/core/SkDebugUtils.h
@@ -6102,8 +6136,6 @@ FILE: ../../../third_party/skia/src/core/SkKeyHelpers.cpp
61026136
FILE: ../../../third_party/skia/src/core/SkKeyHelpers.h
61036137
FILE: ../../../third_party/skia/src/core/SkPaintParamsKey.cpp
61046138
FILE: ../../../third_party/skia/src/core/SkPaintParamsKey.h
6105-
FILE: ../../../third_party/skia/src/core/SkPipelineData.cpp
6106-
FILE: ../../../third_party/skia/src/core/SkPipelineData.h
61076139
FILE: ../../../third_party/skia/src/core/SkSLTypeShared.h
61086140
FILE: ../../../third_party/skia/src/core/SkShaderCodeDictionary.cpp
61096141
FILE: ../../../third_party/skia/src/core/SkShaderCodeDictionary.h
@@ -6181,6 +6213,7 @@ FILE: ../../../third_party/skia/src/gpu/ops/PathStencilCoverOp.h
61816213
FILE: ../../../third_party/skia/src/gpu/ops/PathTessellateOp.cpp
61826214
FILE: ../../../third_party/skia/src/gpu/ops/PathTessellateOp.h
61836215
FILE: ../../../third_party/skia/src/gpu/tessellate/AffineMatrix.h
6216+
FILE: ../../../third_party/skia/src/gpu/tessellate/PatchWriter.cpp
61846217
FILE: ../../../third_party/skia/src/gpu/tessellate/PatchWriter.h
61856218
FILE: ../../../third_party/skia/src/gpu/tessellate/PathCurveTessellator.cpp
61866219
FILE: ../../../third_party/skia/src/gpu/tessellate/PathCurveTessellator.h

ci/licenses_golden/licenses_third_party

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Signature: 80ac7a3b149c4cac0af4058b3b4a4bb6
1+
Signature: 63800bcd154af7272865369dc774c2c4
22

33
UNUSED LICENSES:
44

@@ -18098,6 +18098,7 @@ FILE: ../../../third_party/icu/android_small/icudtl_extra.dat
1809818098
FILE: ../../../third_party/icu/cast/brkitr.patch
1809918099
FILE: ../../../third_party/icu/cast/icudtl.dat
1810018100
FILE: ../../../third_party/icu/chromeos/icudtl.dat
18101+
FILE: ../../../third_party/icu/chromeos/icudtl.dat.hash
1810118102
FILE: ../../../third_party/icu/common/icudtb.dat
1810218103
FILE: ../../../third_party/icu/common/icudtl.dat
1810318104
FILE: ../../../third_party/icu/flutter/brkitr.patch
@@ -18227,6 +18228,7 @@ FILE: ../../../third_party/icu/android_small/icudtl_extra.dat
1822718228
FILE: ../../../third_party/icu/cast/brkitr.patch
1822818229
FILE: ../../../third_party/icu/cast/icudtl.dat
1822918230
FILE: ../../../third_party/icu/chromeos/icudtl.dat
18231+
FILE: ../../../third_party/icu/chromeos/icudtl.dat.hash
1823018232
FILE: ../../../third_party/icu/common/icudtb.dat
1823118233
FILE: ../../../third_party/icu/common/icudtl.dat
1823218234
FILE: ../../../third_party/icu/flutter/brkitr.patch
@@ -18366,6 +18368,7 @@ FILE: ../../../third_party/icu/android_small/icudtl_extra.dat
1836618368
FILE: ../../../third_party/icu/cast/brkitr.patch
1836718369
FILE: ../../../third_party/icu/cast/icudtl.dat
1836818370
FILE: ../../../third_party/icu/chromeos/icudtl.dat
18371+
FILE: ../../../third_party/icu/chromeos/icudtl.dat.hash
1836918372
FILE: ../../../third_party/icu/common/icudtb.dat
1837018373
FILE: ../../../third_party/icu/common/icudtl.dat
1837118374
FILE: ../../../third_party/icu/flutter/brkitr.patch
@@ -18500,6 +18503,7 @@ FILE: ../../../third_party/icu/android_small/icudtl_extra.dat
1850018503
FILE: ../../../third_party/icu/cast/brkitr.patch
1850118504
FILE: ../../../third_party/icu/cast/icudtl.dat
1850218505
FILE: ../../../third_party/icu/chromeos/icudtl.dat
18506+
FILE: ../../../third_party/icu/chromeos/icudtl.dat.hash
1850318507
FILE: ../../../third_party/icu/common/icudtb.dat
1850418508
FILE: ../../../third_party/icu/common/icudtl.dat
1850518509
FILE: ../../../third_party/icu/flutter/brkitr.patch
@@ -18633,6 +18637,7 @@ FILE: ../../../third_party/icu/android_small/icudtl_extra.dat
1863318637
FILE: ../../../third_party/icu/cast/brkitr.patch
1863418638
FILE: ../../../third_party/icu/cast/icudtl.dat
1863518639
FILE: ../../../third_party/icu/chromeos/icudtl.dat
18640+
FILE: ../../../third_party/icu/chromeos/icudtl.dat.hash
1863618641
FILE: ../../../third_party/icu/common/icudtb.dat
1863718642
FILE: ../../../third_party/icu/common/icudtl.dat
1863818643
FILE: ../../../third_party/icu/flutter/brkitr.patch
@@ -18771,6 +18776,7 @@ FILE: ../../../third_party/icu/android_small/icudtl_extra.dat
1877118776
FILE: ../../../third_party/icu/cast/brkitr.patch
1877218777
FILE: ../../../third_party/icu/cast/icudtl.dat
1877318778
FILE: ../../../third_party/icu/chromeos/icudtl.dat
18779+
FILE: ../../../third_party/icu/chromeos/icudtl.dat.hash
1877418780
FILE: ../../../third_party/icu/common/icudtb.dat
1877518781
FILE: ../../../third_party/icu/common/icudtl.dat
1877618782
FILE: ../../../third_party/icu/flutter/brkitr.patch
@@ -18905,6 +18911,7 @@ FILE: ../../../third_party/icu/android_small/icudtl_extra.dat
1890518911
FILE: ../../../third_party/icu/cast/brkitr.patch
1890618912
FILE: ../../../third_party/icu/cast/icudtl.dat
1890718913
FILE: ../../../third_party/icu/chromeos/icudtl.dat
18914+
FILE: ../../../third_party/icu/chromeos/icudtl.dat.hash
1890818915
FILE: ../../../third_party/icu/common/icudtb.dat
1890918916
FILE: ../../../third_party/icu/common/icudtl.dat
1891018917
FILE: ../../../third_party/icu/flutter/brkitr.patch
@@ -19038,6 +19045,7 @@ FILE: ../../../third_party/icu/android_small/icudtl_extra.dat
1903819045
FILE: ../../../third_party/icu/cast/brkitr.patch
1903919046
FILE: ../../../third_party/icu/cast/icudtl.dat
1904019047
FILE: ../../../third_party/icu/chromeos/icudtl.dat
19048+
FILE: ../../../third_party/icu/chromeos/icudtl.dat.hash
1904119049
FILE: ../../../third_party/icu/common/icudtb.dat
1904219050
FILE: ../../../third_party/icu/common/icudtl.dat
1904319051
FILE: ../../../third_party/icu/flutter/brkitr.patch
@@ -19144,6 +19152,7 @@ FILE: ../../../third_party/icu/android_small/icudtl_extra.dat
1914419152
FILE: ../../../third_party/icu/cast/brkitr.patch
1914519153
FILE: ../../../third_party/icu/cast/icudtl.dat
1914619154
FILE: ../../../third_party/icu/chromeos/icudtl.dat
19155+
FILE: ../../../third_party/icu/chromeos/icudtl.dat.hash
1914719156
FILE: ../../../third_party/icu/common/icudtb.dat
1914819157
FILE: ../../../third_party/icu/common/icudtl.dat
1914919158
FILE: ../../../third_party/icu/flutter/brkitr.patch
@@ -19317,6 +19326,7 @@ FILE: ../../../third_party/icu/android_small/icudtl_extra.dat
1931719326
FILE: ../../../third_party/icu/cast/brkitr.patch
1931819327
FILE: ../../../third_party/icu/cast/icudtl.dat
1931919328
FILE: ../../../third_party/icu/chromeos/icudtl.dat
19329+
FILE: ../../../third_party/icu/chromeos/icudtl.dat.hash
1932019330
FILE: ../../../third_party/icu/common/icudtb.dat
1932119331
FILE: ../../../third_party/icu/common/icudtl.dat
1932219332
FILE: ../../../third_party/icu/flutter/brkitr.patch

ci/licenses_golden/tool_signature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Signature: 270842a9eb9687ced20abdf5f131bafd
1+
Signature: 5efe7843d99ba138e2bb7dac2441b5b8
22

lib/web_ui/BUILD.gn

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# Copyright 2022 The Flutter Authors. All rights reserved.
2+
# Use of this source code is governed by a BSD-style license that can be
3+
# found in the LICENSE file.
4+
5+
group("canvaskit") {
6+
deps = [ "//third_party/skia/modules/canvaskit" ]
7+
}

lib/web_ui/README.md

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,59 @@ environment variable:
265265
FELT_USE_SNAPSHOT=false felt <command>
266266
```
267267
268+
## Building CanvasKit
269+
270+
To build CanvasKit locally, you must first set up your gclient config to
271+
activate the Emscripten SDK, which is the toolchain used to build CanvasKit.
272+
To do this, replace the contents of your .gclient file at the root of the
273+
project (i.e. in the parent directory of the `src` directory) with:
274+
275+
```
276+
solutions = [
277+
{
278+
"managed": False,
279+
"name": "src/flutter",
280+
"url": "[email protected]:<your_username_here>/engine.git",
281+
"custom_deps": {},
282+
"deps_file": "DEPS",
283+
"safesync_url": "",
284+
"custom_vars": {
285+
"download_emsdk": True,
286+
},
287+
},
288+
]
289+
```
290+
291+
Now run `gclient sync` and it should pull in the Emscripten SDK and activate it.
292+
293+
To build CanvasKit with `felt`, run:
294+
295+
```
296+
felt build --build-canvaskit
297+
```
298+
299+
This will build CanvasKit in `out/wasm_debug`. If you now run
300+
301+
```
302+
felt test
303+
```
304+
305+
it will detect that you have built CanvasKit and use that instead of the one
306+
from CIPD to run the tests against.
307+
308+
### Upgrading the Emscripten SDK for the CanvasKit build
309+
310+
The version of the Emscripten SDK should be kept up to date with the version
311+
used in the Skia build. That version can be found in
312+
`third_party/skia/bin/activate-emsdk`. It will probably also be necessary to
313+
roll the dependency on `third_party/emsdk` in DEPS to the same version as in
314+
`third_party/skia/DEPS`.
315+
316+
Once you know the version for the Emscripten SDK, change the line in
317+
`tools/activate_emsdk.py` which defines `EMSDK_VERSION` to match Skia.
318+
319+
320+
268321
[1]: https://github.com/flutter/flutter/wiki/Setting-up-the-Engine-development-environment
269322
[2]: https://github.com/flutter/engine/blob/main/lib/web_ui/dev/browser_lock.yaml
270323
[4]: https://chrome-infra-packages.appspot.com/p/flutter_internal

0 commit comments

Comments
 (0)