Skip to content

Commit 4e79678

Browse files
[pointer_interceptor] Remove implements from app-facing package (flutter#6699)
Dart unit tests started failing for `pointer_interceptor` due to the `implements` tag in the app facing package. This plugin is federated for ios and web, so it looks like the error message is valid. ``` Plugin pointer_interceptor:ios provides an implementation for pointer_interceptor_platform_interface and also references a default implementation for pointer_interceptor_ios, which is currently not supported. Ask the maintainers of pointer_interceptor to either remove the implementation via `implements: pointer_interceptor_platform_interface` or avoid referencing a default implementation via `platforms: ios: default_package: pointer_interceptor_ios`. 00:00 +0 -1: loading /b/s/w/ir/x/w/packages/packages/pointer_interceptor/pointer_interceptor/test/tests_exist_elsewhere_test.dart [E] Error: Please resolve the plugin pubspec errors package:flutter_tools/src/base/common.dart 10:3 throwToolExit package:flutter_tools/src/flutter_plugins.dart 1214:5 resolvePlatformImplementation package:flutter_tools/src/flutter_plugins.dart 1418:55 generateMainDartWithPluginRegistrant ===== asynchronous gap =========================== package:flutter_tools/src/test/test_compiler.dart 163:9 TestCompiler._onCompilationRequest TimeoutException after 0:12:00.000000: Test timed out after 12 minutes. package:test_api/src/backend/invoker.dart 338:28 Invoker._handleError.<fn> dart:async/zone.dart 1391:47 _rootRun dart:async/zone.dart 1301:19 _CustomZone.run package:test_api/src/backend/invoker.dart 336:10 Invoker._handleError package:test_api/src/backend/invoker.dart 291:9 Invoker.heartbeat.<fn>.<fn> dart:async/zone.dart 1399:13 _rootRun dart:async/zone.dart 1301:19 _CustomZone.run package:test_api/src/backend/invoker.dart 290:38 Invoker.heartbeat.<fn> dart:async-patch/timer_patch.dart 18:15 Timer._createTimer.<fn> dart:isolate-patch/timer_impl.dart 398:19 _Timer._runTimers dart:isolate-patch/timer_impl.dart 429:5 _Timer._handleMessage dart:isolate-patch/isolate_patch.dart 184:12 _RawReceivePort._handleMessage To run this test again: /b/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test ``` This removes the tag and does a manual roll.
1 parent d670b2c commit 4e79678

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.ci/flutter_master.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7920a52dd5680651118312f9be0600797ff2257e
1+
00f40667c16ae3f7cf0c567fe4a43c0a59046951

packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
## NEXT
1+
## 0.10.1+1
22

33
* Updates support matrix in README to indicate that iOS 11 is no longer supported.
44
* Clients on versions of Flutter that still support iOS 11 can continue to use this
55
package with iOS 11, but will not receive any further updates to the iOS implementation.
6+
* Removes invalid `implements` tag in pubspec.
67

78
## 0.10.1
89

packages/pointer_interceptor/pointer_interceptor/pubspec.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,14 @@ name: pointer_interceptor
22
description: A widget to prevent clicks from being swallowed by underlying HtmlElementViews on the web.
33
repository: https://github.com/flutter/packages/tree/main/packages/pointer_interceptor/pointer_interceptor
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pointer_interceptor%22
5-
version: 0.10.1
5+
version: 0.10.1+1
66

77
environment:
88
sdk: ">=3.1.0 <4.0.0"
99
flutter: ">=3.13.0"
1010

1111
flutter:
1212
plugin:
13-
implements: pointer_interceptor_platform_interface
1413
platforms:
1514
web:
1615
default_package: pointer_interceptor_web

0 commit comments

Comments
 (0)