Skip to content

Commit 5103d75

Browse files
authored
[tool] Remove some usages of deprecated usage package (flutter#151359)
Partially addresses flutter#150575 and flutter#150665 Will require a g3fix.
1 parent 5ebc993 commit 5103d75

26 files changed

+183
-381
lines changed

dev/bots/analyze.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -912,9 +912,8 @@ Future<void> verifyNoTestImports(String workingDirectory) async {
912912
}
913913
// Fail if any errors
914914
if (errors.isNotEmpty) {
915-
final String s = errors.length == 1 ? '' : 's';
916915
foundError(<String>[
917-
'${bold}The following file$s import a test directly. Test utilities should be in their own file.$reset',
916+
'${bold}The following file(s) import a test directly. Test utilities should be in their own file.$reset',
918917
...errors,
919918
]);
920919
}

packages/flutter_tools/lib/src/android/gradle.dart

Lines changed: 10 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import '../convert.dart';
2929
import '../flutter_manifest.dart';
3030
import '../globals.dart' as globals;
3131
import '../project.dart';
32-
import '../reporting/reporting.dart';
3332
import 'android_builder.dart';
3433
import 'android_studio.dart';
3534
import 'gradle_errors.dart';
@@ -149,7 +148,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
149148
required ProcessManager processManager,
150149
required FileSystem fileSystem,
151150
required Artifacts artifacts,
152-
required Usage usage,
153151
required Analytics analytics,
154152
required GradleUtils gradleUtils,
155153
required Platform platform,
@@ -158,7 +156,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
158156
_logger = logger,
159157
_fileSystem = fileSystem,
160158
_artifacts = artifacts,
161-
_usage = usage,
162159
_analytics = analytics,
163160
_gradleUtils = gradleUtils,
164161
_androidStudio = androidStudio,
@@ -170,7 +167,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
170167
final ProcessUtils _processUtils;
171168
final FileSystem _fileSystem;
172169
final Artifacts _artifacts;
173-
final Usage _usage;
174170
final Analytics _analytics;
175171
final GradleUtils _gradleUtils;
176172
final FileSystemUtils _fileSystemUtils;
@@ -304,7 +300,7 @@ class AndroidGradleBuilder implements AndroidBuilder {
304300
@visibleForTesting int? maxRetries,
305301
}) async {
306302
if (!project.android.isSupportedVersion) {
307-
_exitWithUnsupportedProjectMessage(_usage, _logger.terminal, analytics: _analytics);
303+
_exitWithUnsupportedProjectMessage(_logger.terminal, _analytics);
308304
}
309305

310306
final List<ProjectMigrator> migrators = <ProjectMigrator>[
@@ -322,10 +318,8 @@ class AndroidGradleBuilder implements AndroidBuilder {
322318

323319
final bool usesAndroidX = isAppUsingAndroidX(project.android.hostAppGradleRoot);
324320
if (usesAndroidX) {
325-
BuildEvent('app-using-android-x', type: 'gradle', flutterUsage: _usage).send();
326321
_analytics.send(Event.flutterBuildInfo(label: 'app-using-android-x', buildType: 'gradle'));
327322
} else if (!usesAndroidX) {
328-
BuildEvent('app-not-using-android-x', type: 'gradle', flutterUsage: _usage).send();
329323
_analytics.send(Event.flutterBuildInfo(label: 'app-not-using-android-x', buildType: 'gradle'));
330324

331325
_logger.printStatus("${_logger.terminal.warningMark} Your app isn't using AndroidX.", emphasis: true);
@@ -485,7 +479,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
485479
}
486480

487481
final Duration elapsedDuration = sw.elapsed;
488-
_usage.sendTiming('build', 'gradle', elapsedDuration);
489482
_analytics.send(Event.timing(
490483
workflow: 'build',
491484
variableName: 'gradle',
@@ -494,7 +487,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
494487

495488
if (exitCode != 0) {
496489
if (detectedGradleError == null) {
497-
BuildEvent('gradle-unknown-failure', type: 'gradle', flutterUsage: _usage).send();
498490
_analytics.send(Event.flutterBuildInfo(label: 'gradle-unknown-failure', buildType: 'gradle'));
499491

500492
throwToolExit(
@@ -529,7 +521,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
529521
);
530522
final String successEventLabel = 'gradle-${detectedGradleError!.eventLabel}-success';
531523

532-
BuildEvent(successEventLabel, type: 'gradle', flutterUsage: _usage).send();
533524
_analytics.send(Event.flutterBuildInfo(label: successEventLabel, buildType: 'gradle'));
534525

535526
return;
@@ -538,7 +529,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
538529
}
539530
}
540531
final String usageLabel = 'gradle-${detectedGradleError?.eventLabel}-failure';
541-
BuildEvent(usageLabel, type: 'gradle', flutterUsage: _usage).send();
542532
_analytics.send(Event.flutterBuildInfo(label: usageLabel, buildType: 'gradle'));
543533

544534
throwToolExit(
@@ -548,7 +538,7 @@ class AndroidGradleBuilder implements AndroidBuilder {
548538
}
549539

550540
if (isBuildingBundle) {
551-
final File bundleFile = findBundleFile(project, buildInfo, _logger, _usage, _analytics);
541+
final File bundleFile = findBundleFile(project, buildInfo, _logger, _analytics);
552542
final String appSize = (buildInfo.mode == BuildMode.debug)
553543
? '' // Don't display the size when building a debug variant.
554544
: ' (${getSizeAsPlatformMB(bundleFile.lengthSync())})';
@@ -566,7 +556,7 @@ class AndroidGradleBuilder implements AndroidBuilder {
566556
}
567557
// Gradle produced APKs.
568558
final Iterable<String> apkFilesPaths = project.isModule
569-
? findApkFilesModule(project, androidBuildInfo, _logger, _usage, _analytics)
559+
? findApkFilesModule(project, androidBuildInfo, _logger, _analytics)
570560
: listApkPaths(androidBuildInfo);
571561
final Directory apkDirectory = getApkDirectory(project);
572562

@@ -577,7 +567,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
577567
project: project,
578568
fileExtension: '.apk',
579569
logger: _logger,
580-
usage: _usage,
581570
analytics: _analytics,
582571
);
583572
}
@@ -608,7 +597,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
608597
final SizeAnalyzer sizeAnalyzer = SizeAnalyzer(
609598
fileSystem: _fileSystem,
610599
logger: _logger,
611-
flutterUsage: _usage,
612600
analytics: _analytics,
613601
);
614602
final String archName = androidBuildInfo.targetArchs.single.archName;
@@ -759,7 +747,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
759747
status.stop();
760748
}
761749
final Duration elapsedDuration = sw.elapsed;
762-
_usage.sendTiming('build', 'gradle-aar', elapsedDuration);
763750
_analytics.send(Event.timing(
764751
workflow: 'build',
765752
variableName: 'gradle-aar',
@@ -801,7 +788,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
801788
);
802789

803790
final Duration elapsedDuration = sw.elapsed;
804-
_usage.sendTiming('print', 'android build variants', elapsedDuration);
805791
_analytics.send(Event.timing(
806792
workflow: 'print',
807793
variableName: 'android build variants',
@@ -840,7 +826,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
840826
project: project,
841827
);
842828
final Duration elapsedDuration = sw.elapsed;
843-
_usage.sendTiming('outputs', 'app link settings', elapsedDuration);
844829
_analytics.send(Event.timing(
845830
workflow: 'outputs',
846831
variableName: 'app link settings',
@@ -927,8 +912,7 @@ String _calculateSha(File file) {
927912
return _hex(sha1.convert(bytes).bytes);
928913
}
929914

930-
void _exitWithUnsupportedProjectMessage(Usage usage, Terminal terminal, {required Analytics analytics}) {
931-
BuildEvent('unsupported-project', type: 'gradle', eventError: 'gradle-plugin', flutterUsage: usage).send();
915+
void _exitWithUnsupportedProjectMessage(Terminal terminal, Analytics analytics) {
932916
analytics.send(Event.flutterBuildInfo(
933917
label: 'unsupported-project',
934918
buildType: 'gradle',
@@ -959,7 +943,6 @@ Iterable<String> findApkFilesModule(
959943
FlutterProject project,
960944
AndroidBuildInfo androidBuildInfo,
961945
Logger logger,
962-
Usage usage,
963946
Analytics analytics,
964947
) {
965948
final Iterable<String> apkFileNames = _apkFilesFor(androidBuildInfo);
@@ -995,7 +978,6 @@ Iterable<String> findApkFilesModule(
995978
project: project,
996979
fileExtension: '.apk',
997980
logger: logger,
998-
usage: usage,
999981
analytics: analytics,
1000982
);
1001983
}
@@ -1035,7 +1017,12 @@ Iterable<String> listApkPaths(
10351017
}
10361018

10371019
@visibleForTesting
1038-
File findBundleFile(FlutterProject project, BuildInfo buildInfo, Logger logger, Usage usage, Analytics analytics) {
1020+
File findBundleFile(
1021+
FlutterProject project,
1022+
BuildInfo buildInfo,
1023+
Logger logger,
1024+
Analytics analytics,
1025+
) {
10391026
final List<File> fileCandidates = <File>[
10401027
getBundleDirectory(project)
10411028
.childDirectory(camelCase(buildInfo.modeName))
@@ -1091,7 +1078,6 @@ File findBundleFile(FlutterProject project, BuildInfo buildInfo, Logger logger,
10911078
project: project,
10921079
fileExtension: '.aab',
10931080
logger: logger,
1094-
usage: usage,
10951081
analytics: analytics,
10961082
);
10971083
}
@@ -1101,7 +1087,6 @@ Never _exitWithExpectedFileNotFound({
11011087
required FlutterProject project,
11021088
required String fileExtension,
11031089
required Logger logger,
1104-
required Usage usage,
11051090
required Analytics analytics,
11061091
}) {
11071092

@@ -1110,11 +1095,6 @@ Never _exitWithExpectedFileNotFound({
11101095
final String gradleBuildSettings = 'androidGradlePluginVersion: $androidGradlePluginVersion, '
11111096
'fileExtension: $fileExtension';
11121097

1113-
BuildEvent('gradle-expected-file-not-found',
1114-
type: 'gradle',
1115-
settings: gradleBuildSettings,
1116-
flutterUsage: usage,
1117-
).send();
11181098
analytics.send(Event.flutterBuildInfo(
11191099
label: 'gradle-expected-file-not-found',
11201100
buildType: 'gradle',

packages/flutter_tools/lib/src/android/gradle_errors.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import '../base/process.dart';
1010
import '../base/terminal.dart';
1111
import '../globals.dart' as globals;
1212
import '../project.dart';
13-
import '../reporting/reporting.dart';
1413
import 'gradle_utils.dart';
1514

1615
typedef GradleErrorTest = bool Function(String);

packages/flutter_tools/lib/src/android/gradle_utils.dart

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import '../build_info.dart';
1818
import '../cache.dart';
1919
import '../globals.dart' as globals;
2020
import '../project.dart';
21-
import '../reporting/reporting.dart';
2221
import 'android_sdk.dart';
2322

2423
// These are the versions used in the project templates.
@@ -787,11 +786,6 @@ void writeLocalProperties(File properties) {
787786
}
788787

789788
void exitWithNoSdkMessage() {
790-
BuildEvent('unsupported-project',
791-
type: 'gradle',
792-
eventError: 'android-sdk-not-found',
793-
flutterUsage: globals.flutterUsage)
794-
.send();
795789
globals.analytics.send(Event.flutterBuildInfo(
796790
label: 'unsupported-project',
797791
buildType: 'gradle',

packages/flutter_tools/lib/src/base/analyze_size.dart

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import 'package:unified_analytics/unified_analytics.dart';
99
import 'package:vm_snapshot_analysis/treemap.dart';
1010

1111
import '../convert.dart';
12-
import '../reporting/reporting.dart';
1312
import 'common.dart';
1413
import 'file_system.dart';
1514
import 'logger.dart';
@@ -20,19 +19,16 @@ class SizeAnalyzer {
2019
SizeAnalyzer({
2120
required FileSystem fileSystem,
2221
required Logger logger,
23-
required Usage flutterUsage,
2422
required Analytics analytics,
2523
Pattern appFilenamePattern = 'libapp.so',
26-
}) : _flutterUsage = flutterUsage,
27-
_analytics = analytics,
28-
_fileSystem = fileSystem,
29-
_logger = logger,
30-
_appFilenamePattern = appFilenamePattern;
24+
}) : _analytics = analytics,
25+
_fileSystem = fileSystem,
26+
_logger = logger,
27+
_appFilenamePattern = appFilenamePattern;
3128

3229
final FileSystem _fileSystem;
3330
final Logger _logger;
3431
final Pattern _appFilenamePattern;
35-
final Usage _flutterUsage;
3632
final Analytics _analytics;
3733
String? _appFilename;
3834

@@ -91,7 +87,6 @@ class SizeAnalyzer {
9187
);
9288

9389
assert(_appFilename != null);
94-
CodeSizeEvent(type, flutterUsage: _flutterUsage).send();
9590
_analytics.send(Event.codeSizeAnalysis(platform: type));
9691
return apkAnalysisJson;
9792
}
@@ -145,7 +140,6 @@ class SizeAnalyzer {
145140
aotSnapshotJson: processedAotSnapshotJson,
146141
precompilerTrace: json.decode(precompilerTrace.readAsStringSync()) as Map<String, Object?>? ?? <String, Object?>{},
147142
);
148-
CodeSizeEvent(kind, flutterUsage: _flutterUsage).send();
149143
_analytics.send(Event.codeSizeAnalysis(platform: kind));
150144
return apkAnalysisJson;
151145
}

packages/flutter_tools/lib/src/commands/build_ios.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,6 @@ abstract class _BuildIOSSubCommand extends BuildSubCommand {
713713
result,
714714
analytics: globals.analytics,
715715
fileSystem: globals.fs,
716-
flutterUsage: globals.flutterUsage,
717716
logger: globals.logger,
718717
platform: SupportedPlatform.ios,
719718
project: app.project.parent,
@@ -726,7 +725,6 @@ abstract class _BuildIOSSubCommand extends BuildSubCommand {
726725
final SizeAnalyzer sizeAnalyzer = SizeAnalyzer(
727726
fileSystem: globals.fs,
728727
logger: globals.logger,
729-
flutterUsage: globals.flutterUsage,
730728
analytics: analytics,
731729
appFilenamePattern: 'App'
732730
);

packages/flutter_tools/lib/src/commands/build_linux.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ class BuildLinuxCommand extends BuildSubCommand {
9191
sizeAnalyzer: SizeAnalyzer(
9292
fileSystem: globals.fs,
9393
logger: logger,
94-
flutterUsage: globals.flutterUsage,
9594
analytics: analytics,
9695
),
9796
needCrossBuild: needCrossBuild,

packages/flutter_tools/lib/src/commands/build_macos.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ class BuildMacosCommand extends BuildSubCommand {
6767
fileSystem: globals.fs,
6868
logger: globals.logger,
6969
appFilenamePattern: 'App',
70-
flutterUsage: globals.flutterUsage,
7170
analytics: analytics,
7271
),
7372
usingCISystem: usingCISystem,

packages/flutter_tools/lib/src/commands/build_windows.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ class BuildWindowsCommand extends BuildSubCommand {
7171
fileSystem: globals.fs,
7272
logger: globals.logger,
7373
appFilenamePattern: 'app.so',
74-
flutterUsage: globals.flutterUsage,
7574
analytics: analytics,
7675
),
7776
);

packages/flutter_tools/lib/src/context_runner.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ Future<T> runInContext<T>(
102102
processManager: globals.processManager,
103103
fileSystem: globals.fs,
104104
artifacts: globals.artifacts!,
105-
usage: globals.flutterUsage,
106105
analytics: globals.analytics,
107106
gradleUtils: globals.gradleUtils!,
108107
platform: globals.platform,

packages/flutter_tools/lib/src/ios/devices.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,6 @@ class IOSDevice extends Device {
500500
buildResult,
501501
analytics: globals.analytics,
502502
fileSystem: globals.fs,
503-
flutterUsage: globals.flutterUsage,
504503
logger: globals.logger,
505504
platform: SupportedPlatform.ios,
506505
project: package.project.parent,

packages/flutter_tools/lib/src/ios/mac.dart

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import '../migrations/xcode_script_build_phase_migration.dart';
3030
import '../migrations/xcode_thin_binary_build_phase_input_paths_migration.dart';
3131
import '../plugins.dart';
3232
import '../project.dart';
33-
import '../reporting/reporting.dart';
3433
import 'application_package.dart';
3534
import 'code_signing.dart';
3635
import 'migrations/host_app_info_plist_migration.dart';
@@ -155,7 +154,7 @@ Future<XcodeBuildResult> buildXcodeProject({
155154
final FlutterProject project = FlutterProject.current();
156155

157156
final List<ProjectMigrator> migrators = <ProjectMigrator>[
158-
RemoveFrameworkLinkAndEmbeddingMigration(app.project, globals.logger, globals.flutterUsage, globals.analytics),
157+
RemoveFrameworkLinkAndEmbeddingMigration(app.project, globals.logger, globals.analytics),
159158
XcodeBuildSystemMigration(app.project, globals.logger),
160159
ProjectBaseConfigurationMigration(app.project, globals.logger),
161160
ProjectBuildLocationMigration(app.project, globals.logger),
@@ -452,7 +451,6 @@ Future<XcodeBuildResult> buildXcodeProject({
452451
+ getElapsedAsSeconds(sw.elapsed).padLeft(5),
453452
);
454453
final Duration elapsedDuration = sw.elapsed;
455-
globals.flutterUsage.sendTiming(xcodeBuildActionToString(buildAction), 'xcode-ios', elapsedDuration);
456454
globals.analytics.send(Event.timing(
457455
workflow: xcodeBuildActionToString(buildAction),
458456
variableName: 'xcode-ios',
@@ -625,7 +623,6 @@ Future<void> diagnoseXcodeBuildFailure(
625623
required Analytics analytics,
626624
required Logger logger,
627625
required FileSystem fileSystem,
628-
required Usage flutterUsage,
629626
required SupportedPlatform platform,
630627
required FlutterProject project,
631628
}) async {
@@ -639,13 +636,6 @@ Future<void> diagnoseXcodeBuildFailure(
639636
final String command = xcodeBuildExecution.buildCommands.toString();
640637
final String settings = xcodeBuildExecution.buildSettings.toString();
641638

642-
BuildEvent(
643-
label,
644-
type: buildType,
645-
command: command,
646-
settings: settings,
647-
flutterUsage: flutterUsage,
648-
).send();
649639
analytics.send(Event.flutterBuildInfo(
650640
label: label,
651641
buildType: buildType,

0 commit comments

Comments
 (0)