Skip to content

Commit 51ca131

Browse files
[flutter_tools] remove most mocks from Fuchsia device tests (flutter#81789)
1 parent 5575bf3 commit 51ca131

File tree

3 files changed

+949
-913
lines changed

3 files changed

+949
-913
lines changed

packages/flutter_tools/test/general.shard/fuchsia/fuchsia_dev_finder_test.dart

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,30 +10,29 @@ import 'package:flutter_tools/src/base/file_system.dart';
1010
import 'package:flutter_tools/src/base/logger.dart';
1111
import 'package:flutter_tools/src/fuchsia/fuchsia_dev_finder.dart';
1212
import 'package:flutter_tools/src/fuchsia/fuchsia_sdk.dart';
13-
import 'package:mockito/mockito.dart';
13+
import 'package:test/fake.dart';
1414

1515
import '../../src/common.dart';
1616
import '../../src/fake_process_manager.dart';
1717

1818
void main() {
19-
MockFuchsiaArtifacts mockFuchsiaArtifacts;
19+
FakeFuchsiaArtifacts fuchsiaArtifacts;
2020
BufferLogger logger;
2121
MemoryFileSystem memoryFileSystem;
2222
File deviceFinder;
2323

2424
setUp(() {
25-
mockFuchsiaArtifacts = MockFuchsiaArtifacts();
25+
fuchsiaArtifacts = FakeFuchsiaArtifacts();
2626
memoryFileSystem = MemoryFileSystem.test();
2727
logger = BufferLogger.test();
2828
deviceFinder = memoryFileSystem.file('device-finder');
29-
30-
when(mockFuchsiaArtifacts.devFinder).thenReturn(deviceFinder);
29+
fuchsiaArtifacts.devFinder = deviceFinder;
3130
});
3231

3332
group('device-finder list', () {
3433
testWithoutContext('device-finder not found', () {
3534
final FuchsiaDevFinder fuchsiaDevFinder = FuchsiaDevFinder(
36-
fuchsiaArtifacts: mockFuchsiaArtifacts,
35+
fuchsiaArtifacts: fuchsiaArtifacts,
3736
logger: logger,
3837
processManager: FakeProcessManager.any(),
3938
);
@@ -54,7 +53,7 @@ void main() {
5453
]);
5554

5655
final FuchsiaDevFinder fuchsiaDevFinder = FuchsiaDevFinder(
57-
fuchsiaArtifacts: mockFuchsiaArtifacts,
56+
fuchsiaArtifacts: fuchsiaArtifacts,
5857
logger: logger,
5958
processManager: processManager,
6059
);
@@ -75,7 +74,7 @@ void main() {
7574
]);
7675

7776
final FuchsiaDevFinder fuchsiaDevFinder = FuchsiaDevFinder(
78-
fuchsiaArtifacts: mockFuchsiaArtifacts,
77+
fuchsiaArtifacts: fuchsiaArtifacts,
7978
logger: logger,
8079
processManager: processManager,
8180
);
@@ -96,7 +95,7 @@ void main() {
9695
]);
9796

9897
final FuchsiaDevFinder fuchsiaDevFinder = FuchsiaDevFinder(
99-
fuchsiaArtifacts: mockFuchsiaArtifacts,
98+
fuchsiaArtifacts: fuchsiaArtifacts,
10099
logger: logger,
101100
processManager: processManager,
102101
);
@@ -123,7 +122,7 @@ void main() {
123122
]);
124123

125124
final FuchsiaDevFinder fuchsiaDevFinder = FuchsiaDevFinder(
126-
fuchsiaArtifacts: mockFuchsiaArtifacts,
125+
fuchsiaArtifacts: fuchsiaArtifacts,
127126
logger: logger,
128127
processManager: processManager,
129128
);
@@ -133,4 +132,7 @@ void main() {
133132
});
134133
}
135134

136-
class MockFuchsiaArtifacts extends Mock implements FuchsiaArtifacts {}
135+
class FakeFuchsiaArtifacts extends Fake implements FuchsiaArtifacts {
136+
@override
137+
File devFinder;
138+
}

0 commit comments

Comments
 (0)