Skip to content

Commit 5271340

Browse files
authored
Fix usage of WeakPtr valid check (flutter#20106)
1 parent 0097803 commit 5271340

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

shell/common/animator.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ void Animator::BeginFrame(fml::TimePoint vsync_start_time,
158158
task_runners_.GetUITaskRunner()->PostDelayedTask(
159159
[self = weak_factory_.GetWeakPtr(),
160160
notify_idle_task_id = notify_idle_task_id_]() {
161-
if (!self.get()) {
161+
if (!self) {
162162
return;
163163
}
164164
// If our (this task's) task id is the same as the current one
@@ -228,7 +228,7 @@ void Animator::RequestFrame(bool regenerate_layer_tree) {
228228

229229
task_runners_.GetUITaskRunner()->PostTask([self = weak_factory_.GetWeakPtr(),
230230
frame_number = frame_number_]() {
231-
if (!self.get()) {
231+
if (!self) {
232232
return;
233233
}
234234
TRACE_EVENT_ASYNC_BEGIN0("flutter", "Frame Request Pending", frame_number);

shell/common/shell.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1225,7 +1225,7 @@ void Shell::OnFrameRasterized(const FrameTiming& timing) {
12251225
frame_timings_report_scheduled_ = true;
12261226
task_runners_.GetRasterTaskRunner()->PostDelayedTask(
12271227
[self = weak_factory_gpu_->GetWeakPtr()]() {
1228-
if (!self.get()) {
1228+
if (!self) {
12291229
return;
12301230
}
12311231
self->frame_timings_report_scheduled_ = false;

0 commit comments

Comments
 (0)