Skip to content

Commit 585e231

Browse files
authored
Friendlier flutter tool messages for dynamic mode (flutter#26378)
1 parent 17d741e commit 585e231

File tree

7 files changed

+12
-7
lines changed

7 files changed

+12
-7
lines changed

packages/flutter_tools/lib/src/build_info.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ class BuildInfo {
119119
bool get supportsEmulator => isEmulatorBuildMode(mode);
120120
bool get supportsSimulator => isEmulatorBuildMode(mode);
121121
String get modeName => getModeName(mode);
122+
String get friendlyModeName => getFriendlyModeName(mode);
122123

123124
BuildInfo withTargetPlatform(TargetPlatform targetPlatform) =>
124125
BuildInfo(mode, flavor,
@@ -142,6 +143,10 @@ enum BuildMode {
142143

143144
String getModeName(BuildMode mode) => getEnumName(mode);
144145

146+
String getFriendlyModeName(BuildMode mode) {
147+
return snakeCase(getModeName(mode)).replaceAll('_', ' ');
148+
}
149+
145150
// Returns true if the selected build mode uses ahead-of-time compilation.
146151
bool isAotBuildMode(BuildMode mode) {
147152
return mode == BuildMode.profile || mode == BuildMode.release;

packages/flutter_tools/lib/src/bundle.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Future<void> build({
8585

8686
} else if (!fs.file(compilationTraceFilePath).existsSync()) {
8787
// Be forgiving if compilation trace file is missing.
88-
printError('Warning: Ignoring missing compilation training file $compilationTraceFilePath.');
88+
printStatus('No compilation trace available. To optimize performance, consider using --train.');
8989
final File tmp = fs.systemTempDirectory.childFile('flutterEmptyCompilationTrace.txt');
9090
compilationTraceFilePath = (tmp..createSync(recursive: true)).path;
9191

packages/flutter_tools/lib/src/commands/build_aot.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class BuildAotCommand extends BuildSubCommand {
7070
if (!argResults['quiet']) {
7171
final String typeName = artifacts.getEngineType(platform, buildMode);
7272
status = logger.startProgress(
73-
'Building AOT snapshot in ${getModeName(getBuildMode())} mode ($typeName)...',
73+
'Building AOT snapshot in ${getFriendlyModeName(getBuildMode())} mode ($typeName)...',
7474
expectSlowOperation: true,
7575
);
7676
}

packages/flutter_tools/lib/src/commands/build_ios.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class BuildIOSCommand extends BuildSubCommand {
7070
}
7171
final BuildInfo buildInfo = getBuildInfo();
7272
if (forSimulator && !buildInfo.supportsSimulator)
73-
throwToolExit('${toTitleCase(buildInfo.modeName)} mode is not supported for simulators.');
73+
throwToolExit('${toTitleCase(buildInfo.friendlyModeName)} mode is not supported for simulators.');
7474

7575
final String logTarget = forSimulator ? 'simulator' : 'device';
7676

packages/flutter_tools/lib/src/commands/daemon.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ class AppDomain extends Domain {
342342
String isolateFilter,
343343
}) async {
344344
if (await device.isLocalEmulator && !options.buildInfo.supportsEmulator) {
345-
throw '${toTitleCase(options.buildInfo.modeName)} mode is not supported for emulators.';
345+
throw '${toTitleCase(options.buildInfo.friendlyModeName)} mode is not supported for emulators.';
346346
}
347347

348348
// We change the current working directory for the duration of the `start` command.

packages/flutter_tools/lib/src/commands/run.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ class RunCommand extends RunCommandBase {
303303
}
304304

305305
if (!isEmulatorBuildMode(getBuildMode())) {
306-
throwToolExit('${toTitleCase(getModeName(getBuildMode()))} mode is not supported for emulators.');
306+
throwToolExit('${toTitleCase(getFriendlyModeName(getBuildMode()))} mode is not supported for emulators.');
307307
}
308308
}
309309
}

packages/flutter_tools/lib/src/resident_runner.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ class FlutterDevice {
265265
bool shouldBuild,
266266
}) async {
267267
final bool prebuiltMode = hotRunner.applicationBinary != null;
268-
final String modeName = hotRunner.debuggingOptions.buildInfo.modeName;
268+
final String modeName = hotRunner.debuggingOptions.buildInfo.friendlyModeName;
269269
printStatus('Launching ${getDisplayPath(hotRunner.mainPath)} on ${device.name} in $modeName mode...');
270270

271271
final TargetPlatform targetPlatform = await device.targetPlatform;
@@ -324,7 +324,7 @@ class FlutterDevice {
324324
applicationBinary: coldRunner.applicationBinary
325325
);
326326

327-
final String modeName = coldRunner.debuggingOptions.buildInfo.modeName;
327+
final String modeName = coldRunner.debuggingOptions.buildInfo.friendlyModeName;
328328
final bool prebuiltMode = coldRunner.applicationBinary != null;
329329
if (coldRunner.mainPath == null) {
330330
assert(prebuiltMode);

0 commit comments

Comments
 (0)