Skip to content

Commit 7bc9aa2

Browse files
authored
Make sure saveTo returns a Future (flutter#3363)
1 parent 5708731 commit 7bc9aa2

File tree

5 files changed

+8
-4
lines changed

5 files changed

+8
-4
lines changed

packages/cross_file/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.2.0
2+
3+
* **breaking change** Make sure the `saveTo` method returns a `Future` so it can be awaited and users are sure the file has been written to disk.
4+
15
## 0.1.0+2
26

37
* Fix outdated links across a number of markdown files ([#3276](https://github.com/flutter/plugins/pull/3276))

packages/cross_file/lib/src/types/base.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ abstract class XFileBase {
1818
XFileBase(String path);
1919

2020
/// Save the CrossFile at the indicated file path.
21-
void saveTo(String path) async {
21+
Future<void> saveTo(String path) {
2222
throw UnimplementedError('saveTo has not been implemented.');
2323
}
2424

packages/cross_file/lib/src/types/html.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ class XFile extends XFileBase {
108108

109109
/// Saves the data of this CrossFile at the location indicated by path.
110110
/// For the web implementation, the path variable is ignored.
111-
void saveTo(String path) async {
111+
Future<void> saveTo(String path) async {
112112
// Create a DOM container where we can host the anchor.
113113
_target = ensureInitialized('__x_file_dom_element');
114114

packages/cross_file/lib/src/types/io.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ class XFile extends XFileBase {
5757
}
5858

5959
@override
60-
void saveTo(String path) async {
60+
Future<void> saveTo(String path) async {
6161
File fileToSave = File(path);
6262
await fileToSave.writeAsBytes(_bytes ?? (await readAsBytes()));
6363
await fileToSave.create();

packages/cross_file/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: cross_file
22
description: An abstraction to allow working with files across multiple platforms.
33
homepage: https://github.com/flutter/plugins/tree/master/packages/cross_file
4-
version: 0.1.0+2
4+
version: 0.2.0
55

66
dependencies:
77
flutter:

0 commit comments

Comments
 (0)