Skip to content

Commit aabe53c

Browse files
authored
[Fix]: showDateRangePicker with "large" helpText cutoffs the save button (flutter#146049)
Fix flutter#146039 Pre-launch Checklist
1 parent 7719f87 commit aabe53c

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

packages/flutter/lib/src/material/date_picker.dart

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1685,7 +1685,12 @@ class _CalendarRangePickerDialog extends StatelessWidget {
16851685
child: Column(
16861686
crossAxisAlignment: CrossAxisAlignment.start,
16871687
children: <Widget>[
1688-
Text(helpText, style: headlineHelpStyle),
1688+
Text(
1689+
helpText,
1690+
style: headlineHelpStyle,
1691+
maxLines: 1,
1692+
overflow: TextOverflow.ellipsis,
1693+
),
16891694
const SizedBox(height: 8),
16901695
Row(
16911696
children: <Widget>[

packages/flutter/test/material/date_range_picker_test.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,16 @@ void main() {
268268
});
269269
});
270270

271+
testWidgets('Long helpText does not cutoff the save button', (WidgetTester tester) async {
272+
helpText = 'long helpText' * 100;
273+
saveText = 'make it so';
274+
await preparePicker(tester, (Future<DateTimeRange?> range) async {
275+
expect(find.text(helpText!), findsOneWidget);
276+
expect(find.text(saveText!), findsOneWidget);
277+
expect(tester.takeException(), null);
278+
});
279+
});
280+
271281
testWidgets('Material3 has sentence case labels', (WidgetTester tester) async {
272282
await preparePicker(tester, (Future<DateTimeRange?> range) async {
273283
expect(find.text('Save'), findsOneWidget);

0 commit comments

Comments
 (0)