Skip to content

Commit c48c428

Browse files
authored
Xcode 13 as minimum recommended version (flutter#90906)
1 parent afd84ad commit c48c428

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

packages/flutter_tools/lib/src/macos/xcode.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Version get xcodeRequiredVersion => Version(12, 0, 1, text: '12.0.1');
2222

2323
/// Diverging this number from the minimum required version will provide a doctor
2424
/// warning, not error, that users should upgrade Xcode.
25-
Version get xcodeRecommendedVersion => xcodeRequiredVersion;
25+
Version get xcodeRecommendedVersion => Version(13, 0, 0, text: '13.0.0');
2626

2727
/// SDK name passed to `xcrun --sdk`. Corresponds to undocumented Xcode
2828
/// SUPPORTED_PLATFORMS values.

packages/flutter_tools/test/general.shard/macos/xcode_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,28 +189,28 @@ void main() {
189189

190190
testWithoutContext('isRecommendedVersionSatisfactory is true when version meets minimum', () {
191191
xcodeProjectInterpreter.isInstalled = true;
192-
xcodeProjectInterpreter.version = Version(12, 0, 1);
192+
xcodeProjectInterpreter.version = Version(13, 0, 0);
193193

194194
expect(xcode.isRecommendedVersionSatisfactory, isTrue);
195195
});
196196

197197
testWithoutContext('isRecommendedVersionSatisfactory is true when major version exceeds minimum', () {
198198
xcodeProjectInterpreter.isInstalled = true;
199-
xcodeProjectInterpreter.version = Version(13, 0, 0);
199+
xcodeProjectInterpreter.version = Version(14, 0, 0);
200200

201201
expect(xcode.isRecommendedVersionSatisfactory, isTrue);
202202
});
203203

204204
testWithoutContext('isRecommendedVersionSatisfactory is true when minor version exceeds minimum', () {
205205
xcodeProjectInterpreter.isInstalled = true;
206-
xcodeProjectInterpreter.version = Version(12, 3, 0);
206+
xcodeProjectInterpreter.version = Version(13, 3, 0);
207207

208208
expect(xcode.isRecommendedVersionSatisfactory, isTrue);
209209
});
210210

211211
testWithoutContext('isRecommendedVersionSatisfactory is true when patch version exceeds minimum', () {
212212
xcodeProjectInterpreter.isInstalled = true;
213-
xcodeProjectInterpreter.version = Version(12, 0, 2);
213+
xcodeProjectInterpreter.version = Version(13, 0, 2);
214214

215215
expect(xcode.isRecommendedVersionSatisfactory, isTrue);
216216
});

packages/flutter_tools/test/general.shard/macos/xcode_validator_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ void main() {
6969
final ValidationResult result = await validator.validate();
7070
expect(result.type, ValidationType.partial);
7171
expect(result.messages.last.type, ValidationMessageType.hint);
72-
expect(result.messages.last.message, contains('Flutter recommends a minimum Xcode version of 12.0.2'));
73-
}, skip: true); // [intended] Unskip and update when minimum and required check versions diverge.
72+
expect(result.messages.last.message, contains('Flutter recommends a minimum Xcode version of 13.0.0'));
73+
});
7474

7575
testWithoutContext('Emits partial status when Xcode EULA not signed', () async {
7676
final ProcessManager processManager = FakeProcessManager.list(<FakeCommand>[

0 commit comments

Comments
 (0)