Skip to content

Commit cd580e2

Browse files
authored
Adds increment/decrement actions to fuchsia accessibility bridge. (flutter#21049)
1 parent 7ebab5d commit cd580e2

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

shell/platform/fuchsia/flutter/accessibility_bridge.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,10 @@ AccessibilityBridge::GetFlutterSemanticsAction(
356356
// Scroll node to make it visible.
357357
case fuchsia::accessibility::semantics::Action::SHOW_ON_SCREEN:
358358
return flutter::SemanticsAction::kShowOnScreen;
359+
case fuchsia::accessibility::semantics::Action::INCREMENT:
360+
return flutter::SemanticsAction::kIncrease;
361+
case fuchsia::accessibility::semantics::Action::DECREMENT:
362+
return flutter::SemanticsAction::kDecrease;
359363
default:
360364
FML_DLOG(WARNING) << "Unexpected action "
361365
<< static_cast<int32_t>(fuchsia_action)

shell/platform/fuchsia/flutter/accessibility_bridge_unittest.cc

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -633,5 +633,19 @@ TEST_F(AccessibilityBridgeTest, Actions) {
633633
2u, fuchsia::accessibility::semantics::Action::DEFAULT,
634634
unhandled_callback);
635635
EXPECT_EQ(accessibility_delegate_.actions.size(), 3u);
636+
637+
accessibility_bridge_->OnAccessibilityActionRequested(
638+
0u, fuchsia::accessibility::semantics::Action::INCREMENT,
639+
handled_callback);
640+
EXPECT_EQ(accessibility_delegate_.actions.size(), 4u);
641+
EXPECT_EQ(accessibility_delegate_.actions.back(),
642+
std::make_pair(0, flutter::SemanticsAction::kIncrease));
643+
644+
accessibility_bridge_->OnAccessibilityActionRequested(
645+
0u, fuchsia::accessibility::semantics::Action::DECREMENT,
646+
handled_callback);
647+
EXPECT_EQ(accessibility_delegate_.actions.size(), 5u);
648+
EXPECT_EQ(accessibility_delegate_.actions.back(),
649+
std::make_pair(0, flutter::SemanticsAction::kDecrease));
636650
}
637651
} // namespace flutter_runner_test

0 commit comments

Comments
 (0)