Skip to content

Commit dc7fea8

Browse files
authored
Revert "Reland "Enable caching of CPU samples collected at application startup (flutter#89600)" (flutter#90611)" (flutter#91754)
This reverts commit e89a885.
1 parent e89a885 commit dc7fea8

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

packages/flutter_tools/lib/src/base/dds.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ Future<dds.DartDevelopmentService> Function(
1717
bool enableAuthCodes,
1818
bool ipv6,
1919
Uri? serviceUri,
20-
List<String> cachedUserTags,
2120
}) ddsLauncherCallback = dds.DartDevelopmentService.startDartDevelopmentService;
2221

2322
/// Helper class to launch a [dds.DartDevelopmentService]. Allows for us to
@@ -53,8 +52,6 @@ class DartDevelopmentService {
5352
serviceUri: ddsUri,
5453
enableAuthCodes: disableServiceAuthCodes != true,
5554
ipv6: ipv6 == true,
56-
// Enables caching of CPU samples collected during application startup.
57-
cachedUserTags: const <String>['AppStartUp'],
5855
);
5956
unawaited(_ddsInstance?.done.whenComplete(() {
6057
if (!_completer.isCompleted) {

packages/flutter_tools/test/general.shard/resident_runner_test.dart

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1809,12 +1809,11 @@ void main() {
18091809
fakeVmServiceHost = FakeVmServiceHost(requests: <VmServiceExpectation>[]);
18101810
final FakeDevice device = FakeDevice()
18111811
..dds = DartDevelopmentService();
1812-
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri, List<String> cachedUserTags}) {
1812+
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri}) {
18131813
expect(uri, Uri(scheme: 'foo', host: 'bar'));
18141814
expect(enableAuthCodes, isTrue);
18151815
expect(ipv6, isFalse);
18161816
expect(serviceUri, Uri(scheme: 'http', host: '127.0.0.1', port: 0));
1817-
expect(cachedUserTags, <String>['AppStartUp']);
18181817
throw FakeDartDevelopmentServiceException(message:
18191818
'Existing VM service clients prevent DDS from taking control.',
18201819
);
@@ -1857,12 +1856,11 @@ void main() {
18571856
final FakeDevice device = FakeDevice()
18581857
..dds = DartDevelopmentService();
18591858
final Completer<void>done = Completer<void>();
1860-
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri, List<String> cachedUserTags}) async {
1859+
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri}) async {
18611860
expect(uri, Uri(scheme: 'foo', host: 'bar'));
18621861
expect(enableAuthCodes, isFalse);
18631862
expect(ipv6, isTrue);
18641863
expect(serviceUri, Uri(scheme: 'http', host: '::1', port: 0));
1865-
expect(cachedUserTags, <String>['AppStartUp']);
18661864
done.complete();
18671865
return null;
18681866
};
@@ -1889,12 +1887,11 @@ void main() {
18891887
// See https://github.com/flutter/flutter/issues/72385 for context.
18901888
final FakeDevice device = FakeDevice()
18911889
..dds = DartDevelopmentService();
1892-
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri, List<String> cachedUserTags}) {
1890+
ddsLauncherCallback = (Uri uri, {bool enableAuthCodes, bool ipv6, Uri serviceUri}) {
18931891
expect(uri, Uri(scheme: 'foo', host: 'bar'));
18941892
expect(enableAuthCodes, isTrue);
18951893
expect(ipv6, isFalse);
18961894
expect(serviceUri, Uri(scheme: 'http', host: '127.0.0.1', port: 0));
1897-
expect(cachedUserTags, <String>['AppStartUp']);
18981895
throw FakeDartDevelopmentServiceException(message: 'No URI');
18991896
};
19001897
final TestFlutterDevice flutterDevice = TestFlutterDevice(

0 commit comments

Comments
 (0)