Skip to content

Commit e7f9073

Browse files
flardnfield
authored andcommitted
changes for new DlMaskFilter objects (#17)
1 parent a2f7555 commit e7f9073

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

impeller/display_list/display_list_dispatcher.cc

+11-8
Original file line numberDiff line numberDiff line change
@@ -120,15 +120,18 @@ void DisplayListDispatcher::setPathEffect(sk_sp<SkPathEffect> effect) {
120120
}
121121

122122
// |flutter::Dispatcher|
123-
void DisplayListDispatcher::setMaskFilter(sk_sp<SkMaskFilter> filter) {
123+
void DisplayListDispatcher::setMaskFilter(const flutter::DlMaskFilter* filter) {
124124
// Needs https://github.com/flutter/flutter/issues/95434
125-
UNIMPLEMENTED;
126-
}
127-
128-
// |flutter::Dispatcher|
129-
void DisplayListDispatcher::setMaskBlurFilter(SkBlurStyle style,
130-
SkScalar sigma) {
131-
UNIMPLEMENTED;
125+
if (filter == nullptr) {
126+
// Reset everything
127+
return;
128+
}
129+
switch (filter->type()) {
130+
case flutter::DlMaskFilter::kBlur:
131+
case flutter::DlMaskFilter::kUnknown:
132+
UNIMPLEMENTED;
133+
break;
134+
}
132135
}
133136

134137
// |flutter::Dispatcher|

impeller/display_list/display_list_dispatcher.h

+1-4
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,7 @@ class DisplayListDispatcher final : public flutter::Dispatcher {
6363
void setPathEffect(sk_sp<SkPathEffect> effect) override;
6464

6565
// |flutter::Dispatcher|
66-
void setMaskFilter(sk_sp<SkMaskFilter> filter) override;
67-
68-
// |flutter::Dispatcher|
69-
void setMaskBlurFilter(SkBlurStyle style, SkScalar sigma) override;
66+
void setMaskFilter(const flutter::DlMaskFilter* filter) override;
7067

7168
// |flutter::Dispatcher|
7269
void setImageFilter(sk_sp<SkImageFilter> filter) override;

0 commit comments

Comments
 (0)