Skip to content

Commit 145e940

Browse files
authored
Fix memory leak in ExpansionTile. (#147596)
1 parent eeb351c commit 145e940

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

packages/flutter/lib/src/material/expansion_tile.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -613,6 +613,7 @@ class _ExpansionTileState extends State<ExpansionTile> with SingleTickerProvider
613613
void dispose() {
614614
_tileController._state = null;
615615
_animationController.dispose();
616+
_heightFactor.dispose();
616617
_timer?.cancel();
617618
_timer = null;
618619
super.dispose();

packages/flutter/test/material/expansion_tile_test.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import 'package:flutter/foundation.dart';
1111
import 'package:flutter/material.dart';
1212
import 'package:flutter/rendering.dart';
1313
import 'package:flutter_test/flutter_test.dart';
14+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
1415

1516
class TestIcon extends StatefulWidget {
1617
const TestIcon({super.key});
@@ -222,7 +223,10 @@ void main() {
222223
expect(iconColor(collapsedIconKey), foregroundColor);
223224
}, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.iOS, TargetPlatform.macOS }));
224225

225-
testWidgets('ExpansionTile subtitle', (WidgetTester tester) async {
226+
testWidgets('ExpansionTile subtitle',
227+
// TODO(polina-c): remove when fixed https://github.com/flutter/flutter/issues/145600 [leak-tracking-opt-in]
228+
experimentalLeakTesting: LeakTesting.settings.withTracked(classes: const <String>['CurvedAnimation']),
229+
(WidgetTester tester) async {
226230
await tester.pumpWidget(
227231
const MaterialApp(
228232
home: Scaffold(

0 commit comments

Comments
 (0)