Skip to content

Commit 1c153c3

Browse files
authored
Renaming the virtual device Nexus5 name to Nexus5.gce_x86 (#145225)
This is required to match a rename being made for the devices in firebase lab. Also removed `version=24` entry, since thats not supported on Nexus5x, per the firebase team. Bug:b/322830672 *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
1 parent 71606af commit 1c153c3

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

.ci.yaml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -523,10 +523,9 @@ targets:
523523
# "--device", "model=Nexus6P,version=25"
524524
virtual_devices: >-
525525
[
526-
"--device", "model=Nexus5,version=21",
527-
"--device", "model=Nexus5,version=22",
528-
"--device", "model=Nexus5,version=23",
529-
"--device", "model=Nexus5,version=24",
526+
"--device", "model=Nexus5.gce_x86,version=21",
527+
"--device", "model=Nexus5.gce_x86,version=22",
528+
"--device", "model=Nexus5.gce_x86,version=23",
530529
"--device", "model=Nexus6P,version=25",
531530
"--device", "model=Nexus6P,version=26",
532531
"--device", "model=Nexus6P,version=27",
@@ -555,9 +554,9 @@ targets:
555554
# "--device", "model=Nexus6P,version=25"
556555
virtual_devices: >-
557556
[
558-
"--device", "model=Nexus5,version=21",
559-
"--device", "model=Nexus5,version=22",
560-
"--device", "model=Nexus5,version=23",
557+
"--device", "model=Nexus5.gce_x86,version=21",
558+
"--device", "model=Nexus5.gce_x86,version=22",
559+
"--device", "model=Nexus5.gce_x86,version=23",
561560
"--device", "model=Nexus6P,version=25",
562561
"--device", "model=Nexus6P,version=26",
563562
"--device", "model=Nexus6P,version=27",
@@ -586,9 +585,9 @@ targets:
586585
# "--device", "model=Nexus6P,version=25"
587586
virtual_devices: >-
588587
[
589-
"--device", "model=Nexus5,version=21",
590-
"--device", "model=Nexus5,version=22",
591-
"--device", "model=Nexus5,version=23",
588+
"--device", "model=Nexus5.gce_x86,version=21",
589+
"--device", "model=Nexus5.gce_x86,version=22",
590+
"--device", "model=Nexus5.gce_x86,version=23",
592591
"--device", "model=Nexus6P,version=25",
593592
"--device", "model=Nexus6P,version=26",
594593
"--device", "model=Nexus6P,version=27",

0 commit comments

Comments
 (0)