Skip to content

Commit 6f2d0be

Browse files
Reverts "Introduce ChipAnimationStyle to override default chips animations durations (#149245)" (#149847)
Reverts: flutter/flutter#149245 Initiated by: QuncCccccc Reason for reverting: the newly-added unit test might cause the red tree Original PR Author: TahaTesser Reviewed By: {bleroux, Piinks} This change reverts the following previous change: fixes [Custom backgroundColor on Chip makes it flicker between state transitions](flutter/flutter#146730) ### Example preview ![Screenshot 2024-05-28 at 17 40 00](https://github.com/flutter/flutter/assets/48603081/b9117ed2-5afa-4d65-93ae-aa866772ffa1) https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
1 parent 32da263 commit 6f2d0be

12 files changed

+4
-832
lines changed

examples/api/lib/material/chip/chip_attributes.chip_animation_style.0.dart

-164
This file was deleted.

examples/api/test/material/chip/chip_attributes.chip_animation_style.0_test.dart

-135
This file was deleted.

packages/flutter/lib/src/material/action_chip.dart

-5
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ class ActionChip extends StatelessWidget implements ChipAttributes, TappableChip
110110
this.surfaceTintColor,
111111
this.iconTheme,
112112
this.avatarBoxConstraints,
113-
this.chipAnimationStyle,
114113
}) : assert(pressElevation == null || pressElevation >= 0.0),
115114
assert(elevation == null || elevation >= 0.0),
116115
_chipVariant = _ChipVariant.flat;
@@ -146,7 +145,6 @@ class ActionChip extends StatelessWidget implements ChipAttributes, TappableChip
146145
this.surfaceTintColor,
147146
this.iconTheme,
148147
this.avatarBoxConstraints,
149-
this.chipAnimationStyle,
150148
}) : assert(pressElevation == null || pressElevation >= 0.0),
151149
assert(elevation == null || elevation >= 0.0),
152150
_chipVariant = _ChipVariant.elevated;
@@ -197,8 +195,6 @@ class ActionChip extends StatelessWidget implements ChipAttributes, TappableChip
197195
final IconThemeData? iconTheme;
198196
@override
199197
final BoxConstraints? avatarBoxConstraints;
200-
@override
201-
final ChipAnimationStyle? chipAnimationStyle;
202198

203199
@override
204200
bool get isEnabled => onPressed != null;
@@ -237,7 +233,6 @@ class ActionChip extends StatelessWidget implements ChipAttributes, TappableChip
237233
surfaceTintColor: surfaceTintColor,
238234
iconTheme: iconTheme,
239235
avatarBoxConstraints: avatarBoxConstraints,
240-
chipAnimationStyle: chipAnimationStyle,
241236
);
242237
}
243238
}

0 commit comments

Comments
 (0)