Skip to content

Commit daea6e0

Browse files
authored
remove field override, assign to super field instead (#135165)
Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class. Related to dart-lang/language#3332 (discovered during investigations into the violation of that lint).
1 parent 528a281 commit daea6e0

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

packages/flutter_tools/test/commands.shard/hermetic/run_test.dart

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,13 +1335,10 @@ class FakeIOSDevice extends Fake implements IOSDevice {
13351335

13361336
class TestRunCommandForUsageValues extends RunCommand {
13371337
TestRunCommandForUsageValues({
1338-
this.devices,
1339-
});
1340-
1341-
@override
1342-
// devices is not set within usageValues, so we override the field
1343-
// ignore: overridden_fields
1344-
List<Device>? devices;
1338+
List<Device>? devices,
1339+
}) {
1340+
this.devices = devices;
1341+
}
13451342

13461343
@override
13471344
Future<BuildInfo> getBuildInfo({ BuildMode? forcedBuildMode, File? forcedTargetFile }) async {

0 commit comments

Comments
 (0)