Skip to content

Commit cd118da

Browse files
Update a test expectation that depended on an SkParagraph fix (#119756)
This assertion had been disabled because a bug fix was pending in SkParagraph. This PR updates it to match the new behavior. See flutter/flutter#119653
1 parent 7a926dc commit cd118da

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

packages/flutter/test/widgets/selectable_region_test.dart

+1-2
Original file line numberDiff line numberDiff line change
@@ -842,8 +842,7 @@ void main() {
842842
// Add a little offset to cross the boundary between paragraph 2 and 3.
843843
await gesture.moveTo(textOffsetToPosition(paragraph3, 6) + const Offset(0, 1));
844844
expect(paragraph1.selections[0], const TextSelection(baseOffset: 2, extentOffset: 12));
845-
// TODO(jsimmons): reenable this with updated expectations after https://skia-review.googlesource.com/c/skia/+/619838 lands
846-
//expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 8));
845+
expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 9));
847846
expect(paragraph3.selections[0], const TextSelection(baseOffset: 0, extentOffset: 6));
848847

849848
await gesture.up();

0 commit comments

Comments
 (0)