Skip to content

Commit 2c20337

Browse files
committed
Remove name attribute from where it is irrelevant
1 parent d17b3fb commit 2c20337

File tree

2 files changed

+14
-17
lines changed
  • src/test
    • java/org/apache/ibatis/submitted/auto_type_from_non_ambiguous_constructor
    • resources/org/apache/ibatis/submitted/auto_type_from_non_ambiguous_constructor

2 files changed

+14
-17
lines changed

src/test/java/org/apache/ibatis/submitted/auto_type_from_non_ambiguous_constructor/Mapper1.java

+2-5
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,11 @@ public interface Mapper1 {
2626
String SELECT_SQL = "select a.id, a.name, a.type from account a where a.id = #{id}";
2727
String SELECT_WITH_DOB_SQL = "select id, name, type, date '2025-01-05' dob from account where id = #{id}";
2828

29-
@ConstructorArgs({ @Arg(column = "id", name = "accountId"), @Arg(column = "name", name = "accountName"),
30-
@Arg(column = "type", name = "accountType"), })
29+
@ConstructorArgs({ @Arg(column = "id"), @Arg(column = "name"), @Arg(column = "type")})
3130
@Select(SELECT_SQL)
3231
Account getAccountJavaTypesMissing(long id);
3332

34-
@ConstructorArgs({ @Arg(column = "id", name = "accountId"),
35-
@Arg(column = "name", name = "accountName", javaType = String.class),
36-
@Arg(column = "type", name = "accountType"), })
33+
@ConstructorArgs({ @Arg(column = "id"), @Arg(column = "name", javaType = String.class), @Arg(column = "type")})
3734
@Select(SELECT_SQL)
3835
Account3 getAccountPartialTypesProvided(long id);
3936

src/test/resources/org/apache/ibatis/submitted/auto_type_from_non_ambiguous_constructor/Mapper.xml

+12-12
Original file line numberDiff line numberDiff line change
@@ -21,33 +21,33 @@
2121

2222
<resultMap id="nonAmbiguousAccountRM" type="org.apache.ibatis.submitted.auto_type_from_non_ambiguous_constructor.Account">
2323
<constructor>
24-
<idArg name="accountId" column="id" javaType="_long"/>
25-
<arg name="accountName" column="name" javaType="java.lang.String"/>
26-
<arg name="accountType" column="type" javaType="java.lang.String"/>
24+
<idArg column="id" javaType="_long"/>
25+
<arg column="name" javaType="java.lang.String"/>
26+
<arg column="type" javaType="java.lang.String"/>
2727
</constructor>
2828
</resultMap>
2929

3030
<resultMap id="accountRM" type="org.apache.ibatis.submitted.auto_type_from_non_ambiguous_constructor.Account">
3131
<constructor>
32-
<idArg name="accountId" column="id"/>
33-
<arg name="accountName" column="name"/>
34-
<arg name="accountType" column="type"/>
32+
<idArg column="id"/>
33+
<arg column="name"/>
34+
<arg column="type"/>
3535
</constructor>
3636
</resultMap>
3737

3838
<resultMap id="account2RM" type="org.apache.ibatis.submitted.auto_type_from_non_ambiguous_constructor.Account2">
3939
<constructor>
40-
<idArg name="accountId" column="id"/>
41-
<arg name="accountName" column="name"/>
42-
<arg name="accountType" column="type"/>
40+
<idArg column="id"/>
41+
<arg column="name"/>
42+
<arg column="type"/>
4343
</constructor>
4444
</resultMap>
4545

4646
<resultMap id="account3RM" type="org.apache.ibatis.submitted.auto_type_from_non_ambiguous_constructor.Account3">
4747
<constructor>
48-
<idArg name="accountId" column="id"/>
49-
<arg name="accountName" column="name" javaType="java.lang.String" />
50-
<arg name="accountType" column="type"/>
48+
<idArg column="id"/>
49+
<arg column="name" javaType="java.lang.String" />
50+
<arg column="type"/>
5151
</constructor>
5252
</resultMap>
5353

0 commit comments

Comments
 (0)