fix: Return correct name from FlagdProvider (open-feature#126)

Signed-off-by: Austin Drenski <[email protected]>
Signed-off-by: Eric Pattison <[email protected]>

Author: austindrenski

src/OpenFeature.Contrib.Providers.Flagd/FlagdProvider.cs

@@ -27,10 +27,11 @@ namespace OpenFeature.Contrib.Providers.Flagd
     /// </summary>
     public sealed class FlagdProvider : FeatureProvider
     {
+        const string ProviderName = "flagd Provider";
         static int EventStreamRetryBaseBackoff = 1;
         private readonly FlagdConfig _config;
         private readonly Service.ServiceClient _client;
-        private readonly Metadata _providerMetadata = new Metadata("flagd Provider");
+        private readonly Metadata _providerMetadata = new Metadata(ProviderName);
 
         private readonly ICache<string, object> _cache;
         private int _eventStreamRetries;
@@ -121,7 +122,7 @@ internal FlagdProvider(Service.ServiceClient client, FlagdConfig config, ICache<
         /// </summary>
         public static string GetProviderName()
         {
-            return Api.Instance.GetProviderMetadata().Name;
+            return ProviderName;
         }
 
         /// <summary>

test/OpenFeature.Contrib.Providers.Flagd.Test/FlagdProviderTest.cs

@@ -65,7 +65,7 @@ public void BuildClientForPlatform_Should_Throw_Exception_For_Unsupported_DotNet
         [Fact]
         public void TestGetProviderName()
         {
-            Assert.Equal("No-op Provider", FlagdProvider.GetProviderName());
+            Assert.Equal("flagd Provider", FlagdProvider.GetProviderName());
         }
 
         [Fact]