feat(allow-modules): include virtual: in the modules pattern
#425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
requested changes
Mar 23, 2025
|
I have never seen this before, what package manager uses virtual? |
Vite has a convention for them https://vite.dev/guide/api-plugin#virtual-modules-convention and there are frameworks and libraries taking advantage of this. One good example is Remix |
|
PR updated with test cases for Unsure why is now failing when running |
|
not related to the change - I'll try to fix it later. ❤️ |
aladdin-add
approved these changes
Mar 24, 2025
scagood
requested changes
Mar 24, 2025
|
No worries about the types issues! I will write test for the other rules 👍 |
lfantone
force-pushed
the
patch-1
branch
2 times, most recently
from
8cf2ef2 to
d979195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Module Name Pattern to Support Virtual Modules
Description
• Modified the regular expression pattern in the schema definition to allow an optional "virtual:" prefix. This update enables the configuration to recognize virtual modules.
• The updated pattern now supports module identifiers that may start with "virtual:" followed by optionally scoped names and the module name (e.g., "virtual:@scope/module" or "virtual:module").
• Existing validation behavior is preserved for standard module names, ensuring backward compatibility.
• No changes were made to the core logic; only the schema pattern expression has been updated.