Skip to content

no-missing-imports don't support dependencies subpaths #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
piranna opened this issue Dec 27, 2022 · 5 comments
Closed

no-missing-imports don't support dependencies subpaths #75

piranna opened this issue Dec 27, 2022 · 5 comments

Comments

@piranna
Copy link

piranna commented Dec 27, 2022

If an import includes a sub-path, like @scope/package-name/sub-path, it's identified as missing. Not sure if in all the cases, or just only when using the exports field, but in any case it should be easy to fix, get the package sub-path and checks if it exists in the package folder or matches its exports field.

@NullVoxPopuli
Copy link

I just ran in to this, too. gonna disable the rule for now 🙃

@SBoudrias
Copy link

The #4 PR seems to imply this should now work the same as the selected Node.js version 🤔

But I'm running into the same issue with imports inside package.json pointing to polyfills of #prefixed packages.

@piranna
Copy link
Author

piranna commented Feb 26, 2023

I've just found n/no-missing-import doesn't works with scoped packages at all, not sure if it's a bug or a regression.

@scagood
Copy link

scagood commented Nov 7, 2023

Hopefully this is resolved now due to #132

@scagood
Copy link

scagood commented Nov 26, 2023

I am going to assume that this is resolved, and thus I will close this issue.

Please re open it if you still have this issue!

@scagood scagood closed this as completed Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants