Skip to content

Commit ff1635d

Browse files
authored
chore: support ESLint v5 (#144)
Resolves #138 BREAKING CHANGE: dropping support for Node 4 requires a major version bump.
1 parent 9ac5b6f commit ff1635d

18 files changed

+1821
-1837
lines changed

Diff for: .eslintrc.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,13 @@
1515
],
1616
"rules": {
1717
"no-var": "error",
18+
"object-shorthand": "error",
19+
"prefer-arrow-callback": "error",
1820
"prefer-const": "error",
1921
"strict": ["error", "global"],
2022
"eslint-plugin/prefer-placeholders": "error",
2123
"eslint-plugin/test-case-shorthand-strings": "error",
22-
"node/no-unsupported-features": ["error", { "version": 4 }],
24+
"node/no-unsupported-features": ["error", { "version": 6 }],
2325
"prettier/prettier": "error"
2426
}
2527
}

Diff for: .travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
language: node_js
22
node_js:
3-
- 4
43
- 6
54
- 8
5+
- 10
66
cache:
77
directories:
88
- '$HOME/.npm'

Diff for: CHANGELOG.md

+10
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
## 4.0.0
2+
3+
- Added fixer for `promise/no-new-statics` rule
4+
([#133](https://github.com/xjamundx/eslint-plugin-promise/pull/133))
5+
- Support ESLint v5
6+
([#144](https://github.com/xjamundx/eslint-plugin-promise/pull/144))
7+
8+
This is a breaking change that drops support for Node v4. In order to use ESLint
9+
v5 and eslint-plugin-promise v4, you must use Node >=6.
10+
111
## 3.8.0
212

313
- Removed `promise/avoid-new` from recommended configuration

Diff for: README.md

+3-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ Enforce best practices for JavaScript promises.
77
[![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg)](https://github.com/prettier/prettier)
88

99
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
10-
1110
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
1211

1312
- [Installation](#installation)
@@ -37,8 +36,8 @@ also install `eslint-plugin-promise` globally.
3736

3837
## Usage
3938

40-
Add `promise` to the plugins section of your `.eslintrc` configuration file. You
41-
can omit the `eslint-plugin-` prefix:
39+
Add `promise` to the plugins section of your `.eslintrc.json` configuration
40+
file. You can omit the `eslint-plugin-` prefix:
4241

4342
```json
4443
{
@@ -67,7 +66,7 @@ Then configure the rules you want to use under the rules section.
6766
}
6867
```
6968

70-
or start with the recommended rule set
69+
or start with the recommended rule set:
7170

7271
```json
7372
{

0 commit comments

Comments
 (0)