Skip to content

Commit c681aa7

Browse files
authoredJul 8, 2016
Merge pull request #6 from mathieumg/csrf-bug
Fixed crash with `detect-no-csrf-before-method-override` rule
2 parents c539138 + 8929ccc commit c681aa7

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed
 

Diff for: ‎rules/detect-no-csrf-before-method-override.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
2-
* Check and see if CSRF middleware is before methodOverride
3-
* @author Adam Baldwin
2+
* Check and see if CSRF middleware is before methodOverride
3+
* @author Adam Baldwin
44
*/
55

66
//------------------------------------------------------------------------------
@@ -20,6 +20,10 @@ module.exports = function(context) {
2020
nodeValue = token.value;
2121

2222
if (nodeValue === "express") {
23+
if (!node.callee || !node.callee.property) {
24+
return;
25+
}
26+
2327
if (node.callee.property.name === "methodOverride" && csrf) {
2428
context.report(node, "express.csrf() middleware found before express.methodOverride()");
2529
}

0 commit comments

Comments
 (0)
Please sign in to comment.