-
-
Notifications
You must be signed in to change notification settings - Fork 106
Package Modernization #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@nzakas this is awesome. This is what i was in the process of doing on the fork. I'll dig into whatever remains on this issue monday. |
@MarkKragerup Awesome, thank you! 🙏 |
For the release process, I'm thinking of using release-please. I'm curious if others have experience with other systems that they might prefer? |
I like semantic-release |
You might also want to look at renovate for automated dependency updates. |
Thanks @UziTech. I'm not very familiar with semantic-release, but it looks like there's still a need to manually run a release? With release-please, it creates a PR that you merge and then a release is triggered, so it's completely hands-off. @nlf it looks like I don't have permissions to create secrets in this repo. Would it be possible to add me as an admin? If not, would you be able to set up a secret called NPM_TOKEN that contains an npm CI token to use for publishing? |
semantic-release does automatically release as well as update changeling. I've never used release please but it looks like the main difference is that release please adds a PR that needs to be submitted to do a release where semantic-release just releases each commit that bumps the version. |
Ah gotcha. It still looks like semantic-release gets a bit difficult with protected branches? (In terms of updating package.json and then pushing it back to the repo.) |
@darcyclarke @nlf I'm unable to set up any secrets for this repo with the maintainer role. Would it be possible to set me as the owner? Otherwise, I'm stuck doing releases by hand. |
Now that we've moved the repo, this is complete. 🎉 |
The first priority for getting this package into a state where we can make changes is to go through and modernize the repo. Here are the steps:
main
lint
andtest
steps)The text was updated successfully, but these errors were encountered: