Skip to content

Package Modernization #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
nzakas opened this issue Mar 24, 2022 · 10 comments
Closed
5 tasks done

Package Modernization #75

nzakas opened this issue Mar 24, 2022 · 10 comments

Comments

@nzakas
Copy link
Contributor

nzakas commented Mar 24, 2022

The first priority for getting this package into a state where we can make changes is to go through and modernize the repo. Here are the steps:

  • Switch the primary branch to main
  • Set up automated CI testing using GitHub actions (separate lint and test steps)
  • Enforce conventional commits formats on pull requests
  • Update all dependencies to latest
  • Set up a release process
@MarkKragerup
Copy link
Contributor

@nzakas this is awesome. This is what i was in the process of doing on the fork. I'll dig into whatever remains on this issue monday.

@nzakas
Copy link
Contributor Author

nzakas commented Mar 25, 2022

@MarkKragerup Awesome, thank you! 🙏

@nzakas
Copy link
Contributor Author

nzakas commented Mar 25, 2022

For the release process, I'm thinking of using release-please. I'm curious if others have experience with other systems that they might prefer?

@UziTech
Copy link

UziTech commented Mar 25, 2022

I like semantic-release

@UziTech
Copy link

UziTech commented Mar 25, 2022

You might also want to look at renovate for automated dependency updates.

@nzakas
Copy link
Contributor Author

nzakas commented Mar 25, 2022

Thanks @UziTech. I'm not very familiar with semantic-release, but it looks like there's still a need to manually run a release? With release-please, it creates a PR that you merge and then a release is triggered, so it's completely hands-off.

@nlf it looks like I don't have permissions to create secrets in this repo. Would it be possible to add me as an admin? If not, would you be able to set up a secret called NPM_TOKEN that contains an npm CI token to use for publishing?

@UziTech
Copy link

UziTech commented Mar 25, 2022

semantic-release does automatically release as well as update changeling. I've never used release please but it looks like the main difference is that release please adds a PR that needs to be submitted to do a release where semantic-release just releases each commit that bumps the version.

@nzakas
Copy link
Contributor Author

nzakas commented Mar 25, 2022

Ah gotcha. It still looks like semantic-release gets a bit difficult with protected branches? (In terms of updating package.json and then pushing it back to the repo.)

@nzakas
Copy link
Contributor Author

nzakas commented Apr 18, 2022

@darcyclarke @nlf I'm unable to set up any secrets for this repo with the maintainer role. Would it be possible to set me as the owner? Otherwise, I'm stuck doing releases by hand.

@nzakas
Copy link
Contributor Author

nzakas commented Dec 14, 2022

Now that we've moved the repo, this is complete. 🎉

@nzakas nzakas closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants