Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Smoke testing against popular projects #95

Closed
corbinu opened this issue Sep 19, 2016 · 3 comments
Closed

Smoke testing against popular projects #95

corbinu opened this issue Sep 19, 2016 · 3 comments

Comments

@corbinu
Copy link

corbinu commented Sep 19, 2016

This started when I tested the parser against VSCode and found this issue: #92

The test repo can be found here: https://github.com/corbinu/eslint-typescript-smoketest

I setup a set of smoke tests that run against a few popular and large TypeScript projects. I set them up on Gitlab CI since that is what I am most familiar with. I am happy to just keep testing and reporting issues. Or if you guys want to try to integrate them into your bot and CI framework I will help however I can.

I will say that I am thinking they should be broken up as actually two tests for each set of files one that just parses (which after issues #92 is fixed should be green on all of them based on my testing). Then a second smoke test which should have a .eslintrc.json which matches each projects current TSLint config. These would all be failing for now but eventually should turn Green as the rules get fixed.

@nzakas
Copy link
Member

nzakas commented Sep 21, 2016

In the short term, I think it may be best to have you keep running it and report issues. We're still in the experimental phase where we are trying to figure out the best AST structure to use for various things, so it's likely smoke tests will break frequently

Once we hit 1.0.0 and believe the project is stable, then I think it makes sense to have one or more smoke tests we manage to look for regressions.

Thoughts?

@corbinu
Copy link
Author

corbinu commented Sep 22, 2016

Sounds good to me that will give me some time to mature then and then maybe somebody can help me convert them over to Jenkins

@JamesHenry
Copy link
Member

Seems like we are in agreement, thanks a lot @corbinu!

I'll close this issue for now as it has no action items, please feel free to keep reporting any issues that arise from your tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants