Improved parameter validation (#5256)

fabianoms · devyte · commit ad7cb635eda1 · 2018-10-17T17:08:38.000-03:00
diff --git a/libraries/ESP8266WebServer/src/ESP8266WebServer.cpp b/libraries/ESP8266WebServer/src/ESP8266WebServer.cpp
@@ -500,13 +500,13 @@ String ESP8266WebServer::arg(String name) {
 }
 
 String ESP8266WebServer::arg(int i) {
-  if (i < _currentArgCount)
+  if (i >= 0 && i < _currentArgCount)
     return _currentArgs[i].value;
   return "";
 }
 
 String ESP8266WebServer::argName(int i) {
-  if (i < _currentArgCount)
+  if (i >= 0 && i < _currentArgCount)
     return _currentArgs[i].key;
   return "";
 }

Original file line number	Diff line number	Diff line change
`@@ -500,13 +500,13 @@ String ESP8266WebServer::arg(String name) {`
`500`	`500`	`}`
`501`	`501`
`502`	`502`	`String ESP8266WebServer::arg(int i) {`
`503`		`- if (i < _currentArgCount)`
	`503`	`+ if (i >= 0 && i < _currentArgCount)`
`504`	`504`	`return _currentArgs[i].value;`
`505`	`505`	`return "";`
`506`	`506`	`}`
`507`	`507`
`508`	`508`	`String ESP8266WebServer::argName(int i) {`
`509`		`- if (i < _currentArgCount)`
	`509`	`+ if (i >= 0 && i < _currentArgCount)`
`510`	`510`	`return _currentArgs[i].key;`
`511`	`511`	`return "";`
`512`	`512`	`}`