Additional fixes for 32-char ssid

Author: devyte

libraries/ESP8266WiFi/src/ESP8266WiFi.cpp

@@ -72,13 +72,19 @@ void ESP8266WiFiClass::printDiag(Print& p) {
     struct station_config conf;
     wifi_station_get_config(&conf);
 
-    const char* ssid = reinterpret_cast<const char*>(conf.ssid);
+    char ssid[33]; //ssid can be up to 32chars, => plus null term
+    memcpy(ssid, conf.ssid, sizeof(conf.ssid));
+    ssid[32] = 0; //nullterm in case of 32 char ssid
+ 
     p.print("SSID (");
     p.print(strlen(ssid));
     p.print("): ");
     p.println(ssid);
 
-    const char* passphrase = reinterpret_cast<const char*>(conf.password);
+    char passphrase[65];
+    memcpy(passphrase, conf.password, sizeof(conf.password));
+    passphrase[64] = 0;
+
     p.print("Passphrase (");
     p.print(strlen(passphrase));
     p.print("): ");

libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp

@@ -62,7 +62,7 @@ static bool sta_config_equal(const station_config& lhs, const station_config& rh
  * @return equal
  */
 static bool sta_config_equal(const station_config& lhs, const station_config& rhs) {
-    if(strcmp(reinterpret_cast<const char*>(lhs.ssid), reinterpret_cast<const char*>(rhs.ssid)) != 0) {
+    if(strncmp(reinterpret_cast<const char*>(lhs.ssid), reinterpret_cast<const char*>(rhs.ssid), sizeof(lhs.ssid)) != 0) {
         return false;
     }
 

libraries/ESP8266WiFi/src/ESP8266WiFiScan.cpp

@@ -186,8 +186,11 @@ String ESP8266WiFiScanClass::SSID(uint8_t i) {
     if(!it) {
         return "";
     }
+    char tmp[33]; //ssid can be up to 32chars, => plus null term
+    memcpy(tmp, it->ssid, sizeof(it->ssid));
+    tmp[32] = 0; //nullterm in case of 32 char ssid
 
-    return String(reinterpret_cast<const char*>(it->ssid));
+    return String(reinterpret_cast<const char*>(tmp));
 }