Skip to content

Undocumented function fileSize() on SPIFFS #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jindrichsirucek opened this issue Jul 11, 2018 · 5 comments
Closed

Undocumented function fileSize() on SPIFFS #4916

jindrichsirucek opened this issue Jul 11, 2018 · 5 comments

Comments

@jindrichsirucek
Copy link

Hello, Im not sure where to put info about documentation Issue so if this is not the right palce, pls point me to better one...

In here in documentation:
http://esp8266.github.io/Arduino/versions/2.0.0/doc/filesystem.html#directory-object-dir

is missing documentation of direct function fileSize() on object Directory

Directory object (Dir)
The purpose of Dir object is to iterate over files inside a directory. It provides three methods: next(), fileName(), and openFile(mode).

Also Directory example should be changed to this:

Dir dir = SPIFFS.openDir("/data");
while (dir.next()) {
    Serial.print(dir.fileName());
    Serial.println(dir.fileSize());
}

@devyte
Copy link
Collaborator

devyte commented Jul 11, 2018

This is the right place. Please make a PR with your suggestions for discussion.

@devyte devyte added this to the 2.5.0 milestone Jul 11, 2018
@devyte devyte added the waiting for feedback Waiting on additional info. If it's not received, the issue may be closed. label Jul 11, 2018
@jindrichsirucek
Copy link
Author

Hi, thx for feedback and accepting the issue. Im sorry, really new to colaboration in here.. what should I do? make a "PR"? I dont really understand (PR)..

@devyte
Copy link
Collaborator

devyte commented Jul 12, 2018

PR is Pull Request, which means you propose your changes for discussion, testing, and merging into the repo.

@devyte devyte self-assigned this Aug 2, 2018
@jindrichsirucek
Copy link
Author

@devyte thx for explaining of PR.. I have never done that.. I dont know where to really start with PRs..

@jindrichsirucek
Copy link
Author

I have also found another undocumented function SPIFFS.end()..

@devyte devyte added staged-for-release and removed waiting for feedback Waiting on additional info. If it's not received, the issue may be closed. labels Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants