Skip to content

Due dilligence: don't reintroduce ICACHE_RAM_ATTR: core_esp8266_app_entry_noextra4k.cpp and hwdt_app_entry.cpp #8012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dok-net opened this issue May 1, 2021 · 3 comments
Closed

Due dilligence: don't reintroduce ICACHE_RAM_ATTR: core_esp8266_app_entry_noextra4k.cpp and hwdt_app_entry.cpp #8012

dok-net opened this issue May 1, 2021 · 3 comments

Comments

@dok-net
Copy link
Contributor

dok-net commented May 1, 2021

@mhightower83 Please fix da6ec83
@dok-net dok-net changed the title Due dilligence: don't reintroduce ICACHE_RAM_ATTR: core_esp8266_app_entry_noextra4k.cpp Due dilligence: don't reintroduce ICACHE_RAM_ATTR: core_esp8266_app_entry_noextra4k.cpp and hwdt_app_entry.cpp May 1, 2021
@dok-net
Copy link
Contributor Author

dok-net commented May 5, 2021

@mhightower83 core_esp8266_app_entry_noextra4k.cpp? 🙂

@dok-net
Copy link
Contributor Author

dok-net commented May 7, 2021

Fixed by #8013 and #8018 - @mhightower83 Thanks! If you didn't know, mentioning issues in PRs or even commit messages like so, "fixes #8013", triggers GitHub to close the referenced issues automatically when the PR gets merged.

@dok-net dok-net closed this as completed May 7, 2021
@mhightower83
Copy link
Contributor

@dok-net Thanks! I was not aware of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dok-net @mhightower83