Skip to content

Commit 6cf307d

Browse files
me-no-devme-no-dev
authoredJan 14, 2019
Fix copy/paste error in RMT
Fixes: #2316
·
3.3.0-alpha11.0.2-rc1
1 parent 81844f5 commit 6cf307d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎cores/esp32/esp32-hal-rmt.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ bool rmtSetCarrier(rmt_obj_t* rmt, bool carrier_en, bool carrier_level, uint32_t
156156
RMT_MUTEX_LOCK(channel);
157157

158158
RMT.carrier_duty_ch[channel].low = low;
159-
RMT.carrier_duty_ch[channel].low = high;
159+
RMT.carrier_duty_ch[channel].high = high;
160160
RMT.conf_ch[channel].conf0.carrier_en = carrier_en;
161161
RMT.conf_ch[channel].conf0.carrier_out_lv = carrier_level;
162162

2 commit comments

Comments
 (2)

cyberman54 commented on Jan 16, 2019

@cyberman54
cyberman54
on Jan 16, 2019
Contributor

This looks like an important change, but i don't overlook the context.
What side effects had this bug before, is it urgent to update running devices in the field?

cyberman54 commented on Jan 16, 2019

@cyberman54
cyberman54
on Jan 16, 2019
Contributor

Ok, got it, this seems to apply only to the infrared module.

Please sign in to comment.