Skip to content

Commit ce68d72

Browse files
authored
Fixes UART1 and UART2 default pins for ESP32-S3 (#6202)
Summary This PR fixes an issue with UART1 default pins. When using pins RX_1 = 18 and TX_1 = 17, UART1 will display a Break Error on those pins when they are floting (not connected). It also defines RX_2 = 19 and TX_2 = 20 as default pins for UART2. Impact The deaulf pins may look different from the original pinout diagram.
1 parent 6a7bcab commit ce68d72

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

Diff for: cores/esp32/HardwareSerial.cpp

+11-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#ifndef SOC_RX0
1111
#if CONFIG_IDF_TARGET_ESP32
1212
#define SOC_RX0 3
13-
#elif CONFIG_IDF_TARGET_ESP32S2
13+
#elif CONFIG_IDF_TARGET_ESP32S2 || CONFIG_IDF_TARGET_ESP32S3
1414
#define SOC_RX0 44
1515
#elif CONFIG_IDF_TARGET_ESP32C3
1616
#define SOC_RX0 20
@@ -20,7 +20,7 @@
2020
#ifndef SOC_TX0
2121
#if CONFIG_IDF_TARGET_ESP32
2222
#define SOC_TX0 1
23-
#elif CONFIG_IDF_TARGET_ESP32S2
23+
#elif CONFIG_IDF_TARGET_ESP32S2 || CONFIG_IDF_TARGET_ESP32S3
2424
#define SOC_TX0 43
2525
#elif CONFIG_IDF_TARGET_ESP32C3
2626
#define SOC_TX0 21
@@ -35,10 +35,12 @@ void serialEvent(void) {}
3535
#ifndef RX1
3636
#if CONFIG_IDF_TARGET_ESP32
3737
#define RX1 9
38-
#elif CONFIG_IDF_TARGET_ESP32S2
38+
#elif CONFIG_IDF_TARGET_ESP32S2
3939
#define RX1 18
4040
#elif CONFIG_IDF_TARGET_ESP32C3
4141
#define RX1 18
42+
#elif CONFIG_IDF_TARGET_ESP32S3
43+
#define RX1 15
4244
#endif
4345
#endif
4446

@@ -49,6 +51,8 @@ void serialEvent(void) {}
4951
#define TX1 17
5052
#elif CONFIG_IDF_TARGET_ESP32C3
5153
#define TX1 19
54+
#elif CONFIG_IDF_TARGET_ESP32S3
55+
#define TX1 16
5256
#endif
5357
#endif
5458

@@ -60,12 +64,16 @@ void serialEvent1(void) {}
6064
#ifndef RX2
6165
#if CONFIG_IDF_TARGET_ESP32
6266
#define RX2 16
67+
#elif CONFIG_IDF_TARGET_ESP32S3
68+
#define RX2 19
6369
#endif
6470
#endif
6571

6672
#ifndef TX2
6773
#if CONFIG_IDF_TARGET_ESP32
6874
#define TX2 17
75+
#elif CONFIG_IDF_TARGET_ESP32S3
76+
#define TX2 20
6977
#endif
7078
#endif
7179

0 commit comments

Comments
 (0)