Skip to content

Hardwareserial flush TX only #4204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bertmelis opened this issue Jul 25, 2020 · 4 comments
Closed

Hardwareserial flush TX only #4204

bertmelis opened this issue Jul 25, 2020 · 4 comments

Comments

@bertmelis
Copy link
Contributor

uartFlushTxOnly(uart,false);

flush TX only should only flush TX.

This false should be true.

@bertmelis
Copy link
Contributor Author

#4263

@bertmelis
Copy link
Contributor Author

Please solve this one. It's a small mistake with breaking consequences.

It'd be a shame if this slips into a release.

@Miq1
Copy link

Miq1 commented Aug 31, 2020

@bertmelis CI has been fixed an hour ago, so you may close and reopen your PR to pass.

@bertmelis
Copy link
Contributor Author

Merged master branch into the PR. CI passed now.

Could someone please look into this? This error is so obvious but has breaking consequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants