Skip to content

arduino-esp32/esp-idf and v1.0/v2.0 version retrieval differences #5536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drws opened this issue Aug 12, 2021 · 2 comments
Closed

arduino-esp32/esp-idf and v1.0/v2.0 version retrieval differences #5536

drws opened this issue Aug 12, 2021 · 2 comments
Assignees
Labels
Type: Feature request Feature request for Arduino ESP32
Milestone

Comments

@drws
Copy link

drws commented Aug 12, 2021

This is probably more of a feature request than a bug report, concerning both v1.0 and v2.0 branches.

Esp.h provides a runtime function getSdkVersion(), a wrapper for esp-idf's esp_get_idf_version(), which reads version data from esp_idf_version.h containing ESP_IDF_VERSION_* macros.

A similar story is arduino-esp32 version, the esp_arduino_version.h providing ESP_ARDUINO_VERSION_* macros. It has been added only recently to v2.0 branch only. Firstly, I propose esp_arduino_version.h is also ported to v1.0 codebase so the two major Arduino SDK versions are compatible in such basic regard.

However, the arduino-esp32 does not contain getSdkVersion()-analogue function containing its version string, available at runtime. A getSdk2Version() if you will. Second proposal of this issue is that such function is added to v2.0 and v1.0 branches.

This would also make arduino-esp32 version as accessible as esp-idf one is, without needing to include esp_arduino_version.h. Such basic debugging information should probably be most easily accessible.

@VojtechBartoska
Copy link
Contributor

Status update of this issue:

  • we have now version in corresponding headers
  • we need to check matches and what we can do next (need review)

@VojtechBartoska VojtechBartoska added Status: Review needed Issue or PR is awaiting review and removed Status: Awaiting triage Issue is waiting for triage labels Sep 21, 2022
@VojtechBartoska
Copy link
Contributor

VojtechBartoska commented Nov 21, 2022

Status update:
We now have headers and files with all versions, but there is nothing we can do for older released versions.

I'm closing this issue.

@VojtechBartoska VojtechBartoska removed the Status: Review needed Issue or PR is awaiting review label Nov 21, 2022
Repository owner moved this from Todo to Done in Arduino ESP32 Core Project Roadmap Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature request Feature request for Arduino ESP32
Projects
Development

No branches or pull requests

4 participants