From 35fb47ebebc352e43f935c0bf70beb6b0e3629ea Mon Sep 17 00:00:00 2001 From: Rodrigo Garcia Date: Mon, 13 Jun 2022 20:39:45 -0300 Subject: [PATCH 1/2] fixes BLE HID Battery Level Indicator --- libraries/BLE/src/BLEHIDDevice.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libraries/BLE/src/BLEHIDDevice.cpp b/libraries/BLE/src/BLEHIDDevice.cpp index 5a02f496278..3454ec1de8e 100644 --- a/libraries/BLE/src/BLEHIDDevice.cpp +++ b/libraries/BLE/src/BLEHIDDevice.cpp @@ -42,7 +42,10 @@ BLEHIDDevice::BLEHIDDevice(BLEServer* server) { m_batteryLevelCharacteristic = m_batteryService->createCharacteristic((uint16_t) 0x2a19, BLECharacteristic::PROPERTY_READ | BLECharacteristic::PROPERTY_NOTIFY); m_batteryLevelCharacteristic->addDescriptor(batteryLevelDescriptor); - m_batteryLevelCharacteristic->addDescriptor(new BLE2902()); + BLE2902 *batLevelIndicator = new BLE2902(); + // Battery Level Notification is ON by default, making it work always on BLE Pairing and Bonding + batLevelIndicator->setNotifications(true); + m_batteryLevelCharacteristic->addDescriptor(batLevelIndicator); /* * This value is setup here because its default value in most usage cases, its very rare to use boot mode From 2b34b0486b2d9740084c07a5870d8115a7d8a28d Mon Sep 17 00:00:00 2001 From: Rodrigo Garcia Date: Tue, 14 Jun 2022 08:19:37 -0300 Subject: [PATCH 2/2] Fixing identation --- libraries/BLE/src/BLEHIDDevice.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libraries/BLE/src/BLEHIDDevice.cpp b/libraries/BLE/src/BLEHIDDevice.cpp index 3454ec1de8e..5dc6504dac0 100644 --- a/libraries/BLE/src/BLEHIDDevice.cpp +++ b/libraries/BLE/src/BLEHIDDevice.cpp @@ -42,10 +42,10 @@ BLEHIDDevice::BLEHIDDevice(BLEServer* server) { m_batteryLevelCharacteristic = m_batteryService->createCharacteristic((uint16_t) 0x2a19, BLECharacteristic::PROPERTY_READ | BLECharacteristic::PROPERTY_NOTIFY); m_batteryLevelCharacteristic->addDescriptor(batteryLevelDescriptor); - BLE2902 *batLevelIndicator = new BLE2902(); - // Battery Level Notification is ON by default, making it work always on BLE Pairing and Bonding - batLevelIndicator->setNotifications(true); - m_batteryLevelCharacteristic->addDescriptor(batLevelIndicator); + BLE2902 *batLevelIndicator = new BLE2902(); + // Battery Level Notification is ON by default, making it work always on BLE Pairing and Bonding + batLevelIndicator->setNotifications(true); + m_batteryLevelCharacteristic->addDescriptor(batLevelIndicator); /* * This value is setup here because its default value in most usage cases, its very rare to use boot mode