stress.go: add TODO for closing clients

gyuho · gyuho · commit 55bd3834a1eb · 2018-05-14T10:55:28.000-07:00
Signed-off-by: Gyuho Lee &lt;gyuhox@gmail.com&gt;
diff --git a/stress.go b/stress.go
@@ -345,11 +345,14 @@ func newWriteHandlers(gcfg dbtesterpb.ConfigClientMachineAgentControl) (rhs []Re
 		for i := range etcdClients {
 			rhs[i] = newPutEtcd3(etcdClients[i])
 		}
+
+		// TODO: this "done" function may decrease throughput at the end
 		done = func() {
 			for i := range etcdClients {
 				etcdClients[i].Close()
 			}
 		}
+
 	case "zookeeper__r3_5_3_beta", "zetcd__beta":
 		if gcfg.ConfigClientMachineBenchmarkOptions.SameKey {
 			key := sameKey(gcfg.ConfigClientMachineBenchmarkOptions.KeySizeBytes)

Original file line number	Diff line number	Diff line change
`@@ -345,11 +345,14 @@ func newWriteHandlers(gcfg dbtesterpb.ConfigClientMachineAgentControl) (rhs []Re`
`345`	`345`	`for i := range etcdClients {`
`346`	`346`	`rhs[i] = newPutEtcd3(etcdClients[i])`
`347`	`347`	`}`
	`348`	`+`
	`349`	`+ // TODO: this "done" function may decrease throughput at the end`
`348`	`350`	`done = func() {`
`349`	`351`	`for i := range etcdClients {`
`350`	`352`	`etcdClients[i].Close()`
`351`	`353`	`}`
`352`	`354`	`}`
	`355`	`+`
`353`	`356`	`case "zookeeper__r3_5_3_beta", "zetcd__beta":`
`354`	`357`	`if gcfg.ConfigClientMachineBenchmarkOptions.SameKey {`
`355`	`358`	`key := sameKey(gcfg.ConfigClientMachineBenchmarkOptions.KeySizeBytes)`