Skip to content

Commit e4448c4

Browse files
authored
Merge pull request #17634 from callthingsoff/httpresponse_close_after_read
all: call Close() after reading http.Response.Body
2 parents 7f9011a + bc31162 commit e4448c4

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

contrib/lock/client/client.go

+1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ func write(key string, value string, version int64) error {
6969
if err != nil {
7070
log.Fatalf("failed to read request body: %s", err)
7171
}
72+
httpResp.Body.Close()
7273

7374
resp := new(response)
7475
err = json.Unmarshal(respBytes, resp)

server/etcdserver/api/etcdhttp/peer_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ func TestNewPeerHandlerOnRaftPrefix(t *testing.T) {
103103
if err != nil {
104104
t.Fatalf("unexpected io.ReadAll error: %v", err)
105105
}
106+
resp.Body.Close()
106107
if w := "test data"; string(body) != w {
107108
t.Errorf("#%d: body = %s, want %s", i, body, w)
108109
}

0 commit comments

Comments
 (0)